Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

feat(SR): Support SCOORD3D point annotations and IDC bounding box annotations #3

Closed
wants to merge 1 commit into from

Conversation

rodrigobasilio2022
Copy link
Contributor

@rodrigobasilio2022 rodrigobasilio2022 commented Sep 19, 2023

This PR adds the support for SCOORD3D point annotations and IDC bounding box annotations. It depends on OHIF PR OHIF/Viewers#3631, that enables modes to inject customizations in the dicom sr extension. It defines a function that will convert IDC SR annotations to OHIF/Cornerstone compatible ones.

For now, just POINT SCOORD3D annotations and IDC SR bounding boxes are supported, but other annotations will be included in near future. This PR handles SCOORD3D point annotations by projecting them to all images that are distant less than a threshold value, actually set to 0.1. It is important to note that one SCOORD3d can create multiple SCOORD annotations.

@fedorov
Copy link
Member

fedorov commented Sep 19, 2023

It defines a function that will convert IDC SR annotations to OHIF/Cornerstone compatible ones.

As a correction, there is nothing specific to IDC in the samples that were shared for the purposes of developing this functionality. Those SR samples that follow DICOM standard were prepared by IDC, but that's where connection with IDC ends. Those samples follow the standard, without introducing any tool- or project-specific conventions to be relied upon.

I think what you are trying to say in the above is that OHIF/Cornerstone has implementation-specific conventions/requirements, and cannot use standard DICOM SR annotations without applying some transformation to those first.

cc: @dclunie

@igoroctaviano igoroctaviano changed the title feat(SR) : Support SCOORD3D point annotations and IDC bounding box annotations feat(SR): Support SCOORD3D point annotations and IDC bounding box annotations Nov 23, 2023
@igoroctaviano igoroctaviano changed the base branch from main to main-1.0.1 November 23, 2023 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants