-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add-browser-support #35
base: pre-release
Are you sure you want to change the base?
Conversation
7f18e77
to
91007db
Compare
@Imgkl can you please rebase the |
@Imgkl just checking to see if you got the notification :) Please see this comment |
Hey @Peetee06, First of all Sorry, Had to take a break because of some emergency. Couldn't get back to you sooner. I've rebased the pre-release as you suggested. |
Hey @Imgkl, Thank you for rebasing. This PR is now ready for review :) Let me know what you think and if you see any areas we could improve. |
@Imgkl friendly reminder :) |
This PR adds browser support.
I tried to get a mock server running for an integration test. But as far as I understand when running tests with
--platform chrome
, the tests run in a sandbox that doesn't get access to the server.As a workaround we check if the correct client is instantiated.
Builds on #33 and #34, so we should merge those first.