Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add-browser-support #35

Open
wants to merge 10 commits into
base: pre-release
Choose a base branch
from

Conversation

Peetee06
Copy link
Contributor

@Peetee06 Peetee06 commented Nov 22, 2024

This PR adds browser support.

I tried to get a mock server running for an integration test. But as far as I understand when running tests with --platform chrome, the tests run in a sandbox that doesn't get access to the server.

As a workaround we check if the correct client is instantiated.

Builds on #33 and #34, so we should merge those first.

@Imgkl
Copy link
Owner

Imgkl commented Nov 24, 2024

@Peetee06 I've merged the #34 and #33, as they looked good. Once this is gtg lmk, I'll test it as well and we can merge this.

Btw, awesome work on adding tests as well.

@Peetee06 Peetee06 changed the base branch from main to pre-release November 25, 2024 04:44
@Peetee06 Peetee06 force-pushed the feat/add-browser-support branch from 7f18e77 to 91007db Compare November 25, 2024 04:48
@Peetee06
Copy link
Contributor Author

@Imgkl can you please rebase the pre-release branch onto master, so I can fix the remaining conflicts? As soon as I can do that, this PR will be ready for review and I'll ping you again :)

@Peetee06 Peetee06 marked this pull request as ready for review November 27, 2024 16:14
@Peetee06 Peetee06 marked this pull request as draft November 27, 2024 16:15
@Peetee06
Copy link
Contributor Author

Peetee06 commented Dec 4, 2024

@Imgkl just checking to see if you got the notification :) Please see this comment

@Imgkl
Copy link
Owner

Imgkl commented Dec 11, 2024

Hey @Peetee06,

First of all Sorry, Had to take a break because of some emergency. Couldn't get back to you sooner.

I've rebased the pre-release as you suggested.

@Peetee06 Peetee06 marked this pull request as ready for review December 11, 2024 15:55
@Peetee06
Copy link
Contributor Author

Hey @Imgkl,
glad you're back. Hope everything is alright again!

Thank you for rebasing. This PR is now ready for review :) Let me know what you think and if you see any areas we could improve.

@Peetee06
Copy link
Contributor Author

@Imgkl friendly reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants