-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added demo updated for SDL3 #719
base: master
Are you sure you want to change the base?
Added demo updated for SDL3 #719
Conversation
added new demo headers that are updated to SDL3 and have been confirmed to compile and run appropriately on my machine.
added detection for L and R CTRL
added L and R CTRL support
Please move your updated demos to sdl3_* and keep the original sdl_* (or rename to sdl2_*) : SDL3 is still preview and many still rely on SDL2. |
vertices = glMapBuffer(GL_ARRAY_BUFFER, GL_WRITE_ONLY); | ||
elements = glMapBuffer(GL_ELEMENT_ARRAY_BUFFER, GL_WRITE_ONLY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine compiling for Emscripten results in undefined glMapBuffer()
behavior. Replacing it with glMapBufferRange()
works and looks like result is consistent.
vertices =
glMapBufferRange(GL_ARRAY_BUFFER, 0, max_vertex_buffer,
GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT);
elements =
glMapBufferRange(GL_ELEMENT_ARRAY_BUFFER, 0, max_element_buffer,
GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm that's strange, I'll take another look at the code and make the suggested changes
Yeah sure I'll reorganize the directory. I'm not sure how to rewrite the makefile though, I use Windows mainly so I usually use CMake. Could you help me with that? |
added new demo headers that are updated to SDL3 and have been confirmed to compile and run appropriately on my machine.