Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annual fAPAR_max and LAI_max #403
base: develop
Are you sure you want to change the base?
Annual fAPAR_max and LAI_max #403
Changes from 14 commits
797b6b7
a20cfb5
64f7f84
73b4ffb
dbbff60
54053fb
7e4d24a
169c143
88ed9a1
07ea2b2
283c69d
12045d5
ee7895f
9139375
f1dbac6
ee747ca
09621e7
ff3b195
62f8aa2
b0006a0
aea4ba0
87d4206
a077164
feda9f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need to check we are dealing with whole years in the input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether this should be something similar as in
__init__
of scaler, or something much more simple (like checking thatgrowing_season
can be divided by 365 or 366).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - this was tying me in knots as well. I think it needs to be something similar to the scaler init. We want to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I implemented a check for the datetimes. I am sure I have missed something...
Probably a good time to implement tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It currently assumes daily or subdaily inputs