-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Zenodo handling #162
Updating the Zenodo handling #162
Conversation
…ting from zenodo functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #162 +/- ##
===========================================
- Coverage 79.04% 77.88% -1.17%
===========================================
Files 13 13
Lines 3741 3807 +66
===========================================
+ Hits 2957 2965 +8
- Misses 784 842 +58 ☔ View full report in Codecov by Sentry. |
@jacobcook1995 I haven't tested this stuff, but it does it look sensible? Still need to figure out what went wrong with Sam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks sensible to me. Had one minor comment
…g context manager to handle cleanly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a big improvement, just had a few comments
@jacobcook1995 This is changed again with the update to match the changed Zenodo new version process. I think this is a sensible resolution (use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've look through the changes and they all look good to me!
This PR expands a bit of the actual issue described in #161 after feedback from Sam.
--live
and--sandbox
switches to the Zenodo commands to allow data managers to switch the target publication site without having to maintain different config files.publish_dataset
function now does some filename and hash checking to work out how to align the files being provided with what is already online. Docs updated to reflect this.Closes #161