fix the cronjob to take 0 as historylimit (#47)

* fix the cronjob to take 0 as historylimit * update chart version
Improwised · Jul 31, 2023 · 2731eaa · 2731eaa
1 parent 1f82bac
commit 2731eaa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/charts/polymorphic-app/Chart.yaml b/charts/polymorphic-app/Chart.yaml
@@ -4,5 +4,5 @@ description: A Helm chart for deploying any custom applications, specifically po
 maintainers:
   - name: improwised
 type: application
-version: 1.2.6
+version: 1.2.7
 appVersion: 1.0.0
diff --git a/charts/polymorphic-app/templates/cronjob.yaml b/charts/polymorphic-app/templates/cronjob.yaml
@@ -13,12 +13,8 @@ metadata:
     {{- toYaml . | nindent 4 }}
 {{- end }}
 spec:
-{{- with .successfulJobsHistoryLimit | default $.Values.cronJobTemplate.successfulJobsHistoryLimit }}
-  successfulJobsHistoryLimit: {{ toYaml . }}
-{{- end }}
-{{- with .failedJobsHistoryLimit | default $.Values.cronJobTemplate.failedJobsHistoryLimit }}
-  failedJobsHistoryLimit: {{ toYaml . }}
-{{- end }}
+  successfulJobsHistoryLimit: {{ .successfulJobsHistoryLimit  | default $.Values.cronJobTemplate.successfulJobsHistoryLimit | default 0 }}
+  failedJobsHistoryLimit: {{ .failedJobsHistoryLimit   | default $.Values.cronJobTemplate.failedJobsHistoryLimit | default 0 }}
   schedule: {{ .schedule | quote }}
   suspend: {{ .suspend | default false }}
   jobTemplate:

diff --git a/charts/polymorphic-app/values.yaml b/charts/polymorphic-app/values.yaml
@@ -232,8 +232,8 @@ cronJobTemplate:
     # fsGroup: 1001
     # runAsGroup: 1001
     # runAsUser: 1001
-  successfulJobsHistoryLimit: 1
-  failedJobsHistoryLimit: 1
+  # successfulJobsHistoryLimit: 1
+  # failedJobsHistoryLimit: 1
 
 cronJobs:
 #   - name: update-status