feat: new features for polymorphic-app chart #42 (#43)

Added support for successfulJobHistoryLimit and failedJobHistoryLimit for CronJob Added support for dnsConfig for Deployment
Improwised · Jul 3, 2023 · f3daa15 · f3daa15
1 parent 941ed60
commit f3daa15
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 2 deletions.
diff --git a/charts/polymorphic-app/Chart.yaml b/charts/polymorphic-app/Chart.yaml
@@ -4,5 +4,5 @@ description: A Helm chart for deploying any custom applications, specifically po
 maintainers:
   - name: improwised
 type: application
-version: 1.2.2
+version: 1.2.3
 appVersion: 1.0.0
diff --git a/charts/polymorphic-app/templates/cronjob.yaml b/charts/polymorphic-app/templates/cronjob.yaml
@@ -13,6 +13,12 @@ metadata:
     {{- toYaml . | nindent 4 }}
 {{- end }}
 spec:
+{{- with .successfulJobsHistoryLimit | default $.Values.cronJobTemplate.successfulJobsHistoryLimit }}
+  successfulJobsHistoryLimit: {{ toYaml . }}
+{{- end }}
+{{- with .failedJobsHistoryLimit | default $.Values.cronJobTemplate.failedJobsHistoryLimit }}
+  failedJobsHistoryLimit: {{ toYaml . }}
+{{- end }}
   schedule: {{ .schedule | quote }}
   suspend: {{ .suspend | default false }}
   jobTemplate:

diff --git a/charts/polymorphic-app/templates/service.yaml b/charts/polymorphic-app/templates/service.yaml
@@ -152,6 +152,10 @@ spec:
             periodSeconds: {{ .healthcheck.periodSeconds | default $.Values.serviceTemplate.healthcheck.periodSeconds | default "20" }}
           {{- end }}
         {{- end }}
+      {{- with .dnsConfig | default $.Values.workerTemplate.dnsConfig }}
+      dnsConfig:
+{{ toYaml . | indent 8 }}
+      {{- end }}
       {{- with .securityContext | default $.Values.serviceTemplate.securityContext }}
       securityContext:
 {{ toYaml . | indent 8 }}
@@ -296,4 +300,3 @@ spec:
 {{- end }}
 
 {{- end }}
-
diff --git a/charts/polymorphic-app/templates/worker.yaml b/charts/polymorphic-app/templates/worker.yaml
@@ -139,6 +139,10 @@ spec:
             {{- end }}
             successThreshold: 1
         {{- end }}
+      {{- with .dnsConfig | default $.Values.workerTemplate.dnsConfig }}
+      dnsConfig:
+{{ toYaml . | indent 8 }}
+      {{- end }}
       {{- with .securityContext | default $.Values.workerTemplate.securityContext }}
       securityContext:
 {{ toYaml . | indent 8 }}

diff --git a/charts/polymorphic-app/values.yaml b/charts/polymorphic-app/values.yaml
@@ -65,6 +65,16 @@ serviceTemplate:
     # fsGroup: 1001
     # runAsGroup: 1001
     # runAsUser: 1001
+  dnsConfig: {}
+    # nameservers:
+    #   - 192.0.2.1 # this is an example
+    # searches:
+    #   - ns1.svc.cluster-domain.example
+    #   - my.dns.search.suffix
+    # options:
+    #   - name: ndots
+    #     value: "2"
+    #   - name: edns0
   annotations: {}
   nodeSelector: {}
   tolerations: []
@@ -127,6 +137,16 @@ workerTemplate:
     # fsGroup: 1001
     # runAsGroup: 1001
     # runAsUser: 1001
+  dnsConfig: {}
+    # nameservers:
+    #   - 192.0.2.1 # this is an example
+    # searches:
+    #   - ns1.svc.cluster-domain.example
+    #   - my.dns.search.suffix
+    # options:
+    #   - name: ndots
+    #     value: "2"
+    #   - name: edns0
   nodeSelector: {}
 
   tolerations: []
@@ -210,6 +230,8 @@ cronJobTemplate:
     # fsGroup: 1001
     # runAsGroup: 1001
     # runAsUser: 1001
+  successfulJobsHistoryLimit: 1
+  failedJobsHistoryLimit: 1
 
 cronJobs:
 #   - name: update-status