Skip to content

Commit

Permalink
cran hotfix submission
Browse files Browse the repository at this point in the history
  • Loading branch information
IndrajeetPatil committed Mar 6, 2020
1 parent 1907a60 commit 9e9ebb2
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 1,666 deletions.
4 changes: 2 additions & 2 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2020-03-01.
Once it is accepted, delete this file and tag the release (commit ef42b20517).
This package was submitted to CRAN on 2020-03-06.
Once it is accepted, delete this file and tag the release (commit 1907a60003).
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ggstatsplot 0.3.1

This is a hotfix release to correct some of the failing tests and other minor
breakages.
breakages resulting from the new release of `ggplot2 3.3.0`.

MAJOR CHANGES

Expand Down
5 changes: 3 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
## Test environments
* local Windows install, R 3.6.1
* local Windows install, R devel
* ubuntu 14.04 on travis-ci (devel and release)
* win-builder (devel and release)

## R CMD check results

0 errors | 0 warnings | 0 notes

- Maintenance release and major internal refactoring.
- Hotfix release to address some of the breakages resulting from the new
release of `ggplot2`.
1,628 changes: 0 additions & 1,628 deletions docs/articles/tests_and_coverage.html

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion docs/news/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 1 addition & 20 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
Aalen's
aareg
accidently
al
anevaluator
Expand All @@ -23,7 +22,6 @@ cbu
changedate
checkmark
Cikara
clm
Cochrane
codecov
Codecov
Expand All @@ -32,9 +30,6 @@ colorbar
compositional
Conover
correlalogram
couter
covr
covrpage
Cramer
Cramer's
Cramér's
Expand All @@ -48,7 +43,6 @@ d'être
d’être
Delacre
densigram
df
disgustingness
djnavarro
DOI
Expand All @@ -69,28 +63,22 @@ freighteningness
fueleconomy
Gapminder
geoms
ggbarstats
ggbetweenstats
ggcatstats
ggcoefstats
ggcorrmat
ggdotplotstats
gghistostats
ggpiestats
ggplot
ggscatterstats
ggsignif
ggtheme
ggwithinstats
gh
github
Github
Gitter
gla
glm
glmer
GLMM
glmmPQL
GLMMs
glyphs
gof
Expand All @@ -104,6 +92,7 @@ Heteroscedasticy
hexsticker
HFHD
HitCount
hotfix
http
https
hv
Expand All @@ -123,7 +112,6 @@ jitter
js
Kass
labelled
labeller
Lakens
Larntz
ldhf
Expand All @@ -136,16 +124,12 @@ Licence
lifecycle
Likert
linux
lm
machiavellianism
McNemar
McNemar's
McNemar’s
merMod
metafor
Mina
mingw
mlm
modelling
Mora
mpaa
Expand All @@ -169,7 +153,6 @@ pandoc
paulvanderlaken
pb
pearson's
pearson’s
piechart
pkgs
plotgrid
Expand Down Expand Up @@ -197,7 +180,6 @@ RStudio
setosa
softwares
spearman
spearman’s
sphericity
StackOverflow
statsExpressions
Expand All @@ -206,7 +188,6 @@ steve
svg
tblr
TERGM
testthat
tibble
tibbles
tidiers
Expand Down
Binary file removed tests/README_files/figure-gfm/tests-1.png
Binary file not shown.

4 comments on commit 9e9ebb2

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggbarstats.R:54:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:186:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:269:1: style: functions should have cyclomatic complexity of less than 15, this has 55.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:141:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggcorrmat <- function(data,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:90:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:330:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:402:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:403:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:404:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggwithinstats.R:356:7: style: Commented code should be removed.

# testthat::expect_equal(levels(pb1$data[[8]]$annotation), c("*", "**"))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:112:17: style: Commented code should be removed.

#           "list(~italic(p)[ unadjusted ]== 0.825 )"
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:114:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:125:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:133:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:171:13: style: Commented code should be removed.

#       size = c(0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:177:11: style: Commented code should be removed.

#     class = "data.frame"
          ^~~~~~~~~~~~~~~~~~~~

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggbarstats.R:54:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:186:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:269:1: style: functions should have cyclomatic complexity of less than 15, this has 55.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:141:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggcorrmat <- function(data,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:90:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:330:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:402:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:403:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:404:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggwithinstats.R:356:7: style: Commented code should be removed.

# testthat::expect_equal(levels(pb1$data[[8]]$annotation), c("*", "**"))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:112:17: style: Commented code should be removed.

#           "list(~italic(p)[ unadjusted ]== 0.825 )"
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:114:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:125:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:133:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:171:13: style: Commented code should be removed.

#       size = c(0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:177:11: style: Commented code should be removed.

#     class = "data.frame"
          ^~~~~~~~~~~~~~~~~~~~

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggbarstats.R:54:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:186:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:269:1: style: functions should have cyclomatic complexity of less than 15, this has 55.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:141:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggcorrmat <- function(data,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:90:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:330:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:402:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:403:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:404:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggwithinstats.R:356:7: style: Commented code should be removed.

# testthat::expect_equal(levels(pb1$data[[8]]$annotation), c("*", "**"))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:112:17: style: Commented code should be removed.

#           "list(~italic(p)[ unadjusted ]== 0.825 )"
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:114:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:125:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:133:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:171:13: style: Commented code should be removed.

#       size = c(0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:177:11: style: Commented code should be removed.

#     class = "data.frame"
          ^~~~~~~~~~~~~~~~~~~~

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggbarstats.R:54:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:186:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:269:1: style: functions should have cyclomatic complexity of less than 15, this has 55.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:141:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggcorrmat <- function(data,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:90:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:330:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:402:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:403:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:404:1: style: Lines should not be more than 100 characters.

"list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggwithinstats.R:356:7: style: Commented code should be removed.

# testthat::expect_equal(levels(pb1$data[[8]]$annotation), c("*", "**"))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:112:17: style: Commented code should be removed.

#           "list(~italic(p)[ unadjusted ]== 0.825 )"
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:114:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:125:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:133:15: style: Commented code should be removed.

#         class = "factor"
              ^~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:171:13: style: Commented code should be removed.

#       size = c(0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-pairwise_ggsignif.R:177:11: style: Commented code should be removed.

#     class = "data.frame"
          ^~~~~~~~~~~~~~~~~~~~

Please sign in to comment.