Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing window to narrow profile offsets connection lines #77

Open
b-erv opened this issue Aug 9, 2018 · 7 comments
Open

Resizing window to narrow profile offsets connection lines #77

b-erv opened this issue Aug 9, 2018 · 7 comments

Comments

@b-erv
Copy link

b-erv commented Aug 9, 2018

When the Yarn window is close to or at its minimum width, any lines between nodes get shunted to one side and no longer line up. Happening for me consistently at various resolutions and display magnification settings.
resize

@blurymind
Copy link
Collaborator

blurymind commented Aug 9, 2018 via email

@b-erv
Copy link
Author

b-erv commented Aug 10, 2018

Yes, the same behaviour is occurring for me across versions. Additionally, it happens the same way with all .yarn files, even newly-created ones. Such as here:
demo.yarn.txt

@julsam
Copy link
Contributor

julsam commented Aug 11, 2018

I've been able to reproduce the issue with the NWjs build (aka master) but not with the electron build.

Maybe it has to do with this? Not sure.

/* --- MEDIA --- */

@media (max-width: 830px) {
	.app-search {
		position: relative;
		float: left;
	}
	.app-menu {
		position: relative;
		float: right;
		margin-top: 20px;
	}
}

@blurymind
Copy link
Collaborator

for the electron build - if it aint broke - no need to fix it :) might cause some regression

@julsam
Copy link
Contributor

julsam commented Aug 11, 2018

@blurymind you misunderstood me 😉
I was pointing out that the issue could be related to this css rule in the master branch, not the electron one 😛

This css rule will move the right menu buttons when the window's width is lower than 830px, which is when the issue with the arrows seems to be happening.
But I've only been working in the electron branch so far, so I'm not sure what's really happening, I'll let others investigate.

@blurymind
Copy link
Collaborator

@julsam do we patch it in the nwjs version? I want to focus on maintaining the electron one

@julsam
Copy link
Contributor

julsam commented Aug 25, 2018

@blurymind it's not a major bug, so i'm not sure patching the nwjs is worth it since the plan is to go full electron in the long term. There's a lot more important issues to fix in the nwjs version anyway (but i'm more focused on the electron branch myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants