[PH-38] Instance types setting cannot be saved properly (#499)

Signed-off-by: raymond nguyen <[email protected]>
InfuseAI · Feb 23, 2024 · 87cb0a2 · 87cb0a2
1 parent 21c52f3
commit 87cb0a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/client/src/admin/InstanceTypes/InstanceTypeForm.tsx b/packages/client/src/admin/InstanceTypes/InstanceTypeForm.tsx
@@ -232,10 +232,9 @@ export function _InstanceTypeForm({
 
   React.useEffect(() => {
     if (data) {
-      if (data?.tolerations.length > 0) {
-        const tolerations = data.tolerations.map(t => omit(t, ['__typename']));
-        setTolerations(tolerations);
-      }
+
+      const tolerations = data.tolerations.map(t => omit(t, ['__typename']));
+      setTolerations(tolerations);
 
       if (data?.groups.length > 0) {
         dispatchUserGroups({ type: 'GROUPS', groups: data.groups });

diff --git a/packages/graphql-server/src/resolvers/instanceType.ts b/packages/graphql-server/src/resolvers/instanceType.ts
@@ -179,6 +179,7 @@ export const updateMapping = (data: any) => {
   expectInputLargerThanZero(data.memoryLimit, 'memoryLimit');
 
   const tolerations = validateAndMapTolerations(get(data, 'tolerations.set'), 'update');
+  const nodeSelector = (data.nodeSelector && isEmpty(data.nodeSelector)) ? null : data.nodeSelector;
 
   return {
     metadata: {
@@ -192,7 +193,7 @@ export const updateMapping = (data: any) => {
       'limits.nvidia.com/gpu': data.gpuLimit,
       'requests.cpu': data.cpuRequest,
       'requests.memory': parseRequestField(data.memoryRequest, stringifyMemory),
-      'nodeSelector': data.nodeSelector,
+      'nodeSelector': nodeSelector,
       tolerations,
     }
   };