when creating a route with the 'some' method, methods are case insens…

…itive
IngeniozIT · Feb 25, 2024 · 1931e1e · 1931e1e
1 parent d1abfe4
commit 1931e1e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Route.php b/src/Route.php
@@ -115,7 +115,7 @@ public static function some(array $methods, string $path, mixed $callback, ?stri
     {
         $method = 0;
         foreach ($methods as $methodString) {
-            $method |= self::METHODS[$methodString];
+            $method |= self::METHODS[strtoupper($methodString)];
         }
 
         return new self($method, $path, $callback, $name, $where, $with);

diff --git a/tests/RouteTest.php b/tests/RouteTest.php
@@ -76,18 +76,21 @@ public static function providerRouteMethods(): array
 
     public function testCanMatchSomeMethods(): void
     {
-        $route = Route::some(['GET', 'POST'], '/', 'foo');
+        $route = Route::some(['GET', 'POST', 'delete'], '/', 'foo');
         $getRequest = self::serverRequest('GET', '/');
         $postRequest = self::serverRequest('POST', '/');
         $putRequest = self::serverRequest('PUT', '/');
+        $deleteRequest = self::serverRequest('DELETE', '/');
 
         $getResult = $route->match($getRequest);
         $postResult = $route->match($postRequest);
         $putResult = $route->match($putRequest);
+        $deleteResult = $route->match($deleteRequest);
 
         self::assertSame([], $getResult);
         self::assertSame([], $postResult);
         self::assertSame(false, $putResult);
+        self::assertSame([], $deleteResult);
     }
 
     public function testMatchesRequestsBasedOnPath(): void