fix: 🐛 json error bodyresponse

Inist-CNRS · Oct 25, 2023 · 4ad1789 · 4ad1789
1 parent 66ea68a
commit 4ad1789
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/packages/core/src/index.js b/packages/core/src/index.js
@@ -3,7 +3,6 @@ import writeTo from 'stream-write';
 import globalModules from 'global-modules';
 import { resolve } from 'path';
 import LRU from 'lru-cache';
-import _ from 'lodash';
 import Engine from './engine';
 import Script, { parseCommand } from './script';
 import File from './file';

diff --git a/packages/core/src/server/errorHandler.js b/packages/core/src/server/errorHandler.js
@@ -5,13 +5,15 @@ import { httpRequestErrorTotal }  from './metrics';
 const errorHandler = (request, response) => (error, code = 400) => {
     debug('ezs')('Server has caught an error', error);
     httpRequestErrorTotal.labels(request.pathName).inc();
-    if (!response.headersSent) {
-        response.setHeader('Content-Type', 'text/plain');
-        response.setHeader('Content-Disposition', 'inline');
-        response.writeHead(code, { 'X-Error': Parameter.encode(error.toString()) });
-        response.write(JSON.stringify(error));
+    if (response.headersSent) {
+        return response.end();
     }
-    response.end();
+    const bodyResponse = JSON.stringify(error);
+    response.setHeader('Content-Type', 'application/json');
+    response.setHeader('Content-Length', bodyResponse.length);
+    response.setHeader('Content-Disposition', 'inline');
+    response.writeHead(code, { 'X-Error': Parameter.encode(error.toString()) });
+    return response.end(bodyResponse);
 };
 
 export default errorHandler;