Merge pull request #390 from Inist-CNRS/fix-csv-export-null-undefined

fix: 🐛 avoid to produce null with undefined value
Inist-CNRS · Dec 19, 2023 · 4b64445 · 4b64445
2 parents 0667dff + 14798ad
commit 4b64445
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/basics/src/csv-string.js b/packages/basics/src/csv-string.js
@@ -1,14 +1,17 @@
 import CSV from 'csv-string';
 
+const isNullOrUndefined = (value) => (value === undefined || value === null);
+
 function strict(data, sep) {
     const q = new RegExp('"', 'g');
     let line = '';
     let s = '';
     Object.keys(data).forEach((key) => {
+        const cell = isNullOrUndefined(data[key]) ?  '' : data[key];
         line = line.concat(
             s
                 .concat('"')
-                .concat(String(data[key]).replace(q, '""'))
+                .concat(String(cell).replace(q, '""'))
                 .concat('"'),
         );
         s = sep;

diff --git a/packages/basics/test/basics.js b/packages/basics/test/basics.js
@@ -107,16 +107,19 @@ describe('test', () => {
         from([
             ['a', 'b', 'c'],
             [1, 2, 3],
-            [4, undefined, 6],
+            [null, undefined, ''],
         ])
             .pipe(ezs('CSVObject'))
             .pipe(ezs('CSVString', { format: 'strict' }))
             .on('data', (chunk) => {
                 res.push(chunk);
             })
             .on('end', () => {
+                console.log(res);
                 assert.equal(3, res.length);
                 assert.equal('"a";"b";"c"\r\n', res[0]);
+                assert.equal('"1";"2";"3"\r\n', res[1]);
+                assert.equal('"";"";""\r\n', res[2]);
                 done();
             });
     });