Merge pull request #392 from Inist-CNRS/identify-undefined

fix: 🐛 with undefined data
Inist-CNRS · Dec 19, 2023 · 67b5d3b · 67b5d3b
2 parents 8240602 + 12b14c0
commit 67b5d3b
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 10 deletions.
diff --git a/packages/core/src/statements/identify.js b/packages/core/src/statements/identify.js
@@ -50,17 +50,22 @@ export default async function identify(data, feed) {
     if (this.isLast()) {
         return feed.close();
     }
-    if (!validKey(uri)) {
-        let identifier;
-        if (scheme === 'uid') {
-            identifier = await generate(nolookalikes, 8);
-        } else if (scheme === 'sha') {
-            identifier = await sha(JSON.stringify(data));
-        }
-        if (identifier) {
-            const checksum = ncda(identifier, nolookalikes);
-            _.set(data, path, `${scheme}:/${identifier}${checksum}`);
+    try {
+        if (!validKey(uri)) {
+            let identifier;
+            if (scheme === 'uid') {
+                identifier = await generate(nolookalikes, 8);
+            } else if (scheme === 'sha') {
+                identifier = await sha(data);
+            }
+            if (identifier) {
+                const checksum = ncda(identifier, nolookalikes);
+                _.set(data, path, `${scheme}:/${identifier}${checksum}`);
+            }
         }
     }
+    catch (e) {
+        return feed.stop(e);
+    }
     return feed.send(data);
 }
diff --git a/packages/core/test/identify.js b/packages/core/test/identify.js
@@ -90,6 +90,29 @@ describe('[identify]', () => {
                 done();
             });
     });
+
+    it('identify #2', (done) => {
+        from([
+            { id: 1, b: 'a' },
+            undefined,
+            { id: 1, b: 'a' },
+        ])
+            .pipe(ezs('identify', { path: 'uuid', scheme: 'sha' }))
+            .pipe(ezs.catch())
+            .on('error', (e) => {
+                try {
+                    expect(e.message).toEqual(expect.stringContaining('Received undefined'));
+                    done();
+                } catch(ee) {
+                    done(ee);
+                }
+            })
+            .on('data', () => true)
+            .on('end', () => {
+                done(new Error('Error is the right behavior'));
+            });
+    });
+
 });
 
 describe('validKey', () => {