Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jest mongo and ezs/lodex mention #396

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Remove jest mongo and ezs/lodex mention #396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c67d1c
chore: remove jest mongo and ezs/lodex mention
AlasDiablo Jan 25, 2024
385b47d
Merge branch 'master' into remove-mongo-lodex
touv Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
*

# White list only the required files
!package-lock.json
!yarn.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: ‏Why do you whitelist yarn.lock ?

Isn't it like package-lock.json, which you just removed from the white list ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of the use of yarn.
It was likely introduced during a lerna update.

!package.json
!packages/
!jest.config.js
!jest-mongodb-config.js
!lerna.json
!babel.config.js
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v18.18.2
17 changes: 0 additions & 17 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,20 +227,3 @@ Add the new package in the list of the [root's README](./README.md).
### Add the package in the gh-pages

Add the new package in the [documentation side bar](./docs/_sidebar.md).

## TroubleShooting

If your tests don't pass in `packages/lodex/test/mongoQuery.spec.js`, you may be
behind a proxy.

It uses [mongo-unit](https://www.npmjs.com/package/mongo-unit) which in turn
uses [mongodb-prebuilt](https://www.npmjs.com/package/mongodb-prebuilt), which
uses [mongodb-download](https://www.npmjs.com/package/mongodb-download), which
tries to download, at first run (that is, the first time you launch the tests,
not at install time), a prebuilt version of MongoDB.

It puts it into `~/.mongodb-prebuilt/mongodb-download/`. But if you are behind a
proxy, the download won't work.

The only solution we found is to launch the test on a network without proxy *at
least once*. Once the file is downloaded, tests will work.
1 change: 0 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ WORKDIR /app

COPY lerna.json ./
COPY babel.config.js ./
COPY jest-mongodb-config.js ./
COPY jest.config.js ./

# Following lines allow to generate & install node_modules
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ The standard package is [@ezs/core](./packages/core#readme), which contains its
- [@ezs/conditor](./packages/conditor#readme) [![npm version](https://img.shields.io/npm/v/@ezs/conditor)](https://npm.im/@ezs/conditor)
- [@ezs/istex](./packages/istex#readme) [![npm version](https://img.shields.io/npm/v/@ezs/istex)](https://npm.im/@ezs/istex)
- [@ezs/libpostal](./packages/libpostal#readme) [![npm version](https://img.shields.io/npm/v/@ezs/libpostal)](https://npm.im/@ezs/libpostal)
- [@ezs/lodex](./packages/lodex#readme) [![npm version](https://img.shields.io/npm/v/@ezs/lodex)](https://npm.im/@ezs/lodex)
- [@ezs/loterre](./packages/loterre#readme) [![npm version](https://img.shields.io/npm/v/@ezs/loterre)](https://npm.im/@ezs/loterre)
- [@ezs/sparql](./packages/sparql#readme) [![npm version](https://img.shields.io/npm/v/@ezs/sparql)](https://npm.im/@ezs/sparql)
- [@ezs/spawn](./packages/spawn#readme) [![npm version](https://img.shields.io/npm/v/@ezs/spawn)](https://npm.im/@ezs/spawn)
Expand Down
12 changes: 0 additions & 12 deletions jest-mongodb-config.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const options = {
collectCoverage: true,
coveragePathIgnorePatterns: ['/node_modules/', '/test/', '/lib/', '/lodex/src/reducers/'],
coverageReporters: ['lcov', 'text-summary'],
preset: '@shelf/jest-mongodb',
transformIgnorePatterns: [
'/node_modules/(?!quick-lru)'
],
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"@babel/plugin-transform-modules-commonjs": "7.13.8",
"@babel/preset-env": "7.13.15",
"@babel/register": "7.13.14",
"@shelf/jest-mongodb": "1.2.4",
"@types/jest": "26.0.22",
"@types/ramda": "0.27.40",
"array-parallel": "0.1.3",
Expand Down
Loading