Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for TypeScript support #34

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Conversation

hossam-magdy
Copy link
Contributor

@hossam-magdy hossam-magdy commented Feb 29, 2020

This PR adds/declares the detailed types based on the documentation, in index.d.ts so that the library would be TypeScript friendly.

Resolves issue #32

@hossam-magdy hossam-magdy changed the title Add types for TypeScript support Add typings for TypeScript support Feb 29, 2020
@Matthew-Smith
Copy link

The import should be outside of the namespace declaration:

import { Transform } from "stream";
declare namespace CsvString {

@touv touv merged commit 461540a into Inist-CNRS:master Mar 23, 2020
@hossam-magdy hossam-magdy deleted the add-types branch March 23, 2020 10:40
@touv
Copy link
Collaborator

touv commented Mar 23, 2020

Thanks,
see the new release : [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants