Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend for tournament administration #173

Open
wants to merge 96 commits into
base: dev
Choose a base branch
from
Open

Frontend for tournament administration #173

wants to merge 96 commits into from

Conversation

istar410
Copy link
Contributor

@istar410 istar410 commented Jan 24, 2025 •
edited
Loading

Description

The objective is to provide a better user interface for the admin tournament team to manage tournaments.

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Will fix #127

To do

  • Teams :
    • List of teams and their seeding
  • Groups :
    • Groups creation
    • List of groups with score summaries
    • Tiebreak scores inside groups
    • Edit Group :
      • name
      • teams
      • teams seeding
      • teams' tiebreak score
    • Groups' matchs creation
    • Detail list of groups' matchs
    • Launch groups' matchs by round
    • Launch a selection of groups' matchs
    • Edit group match :
      • BO type
      • teams
  • Swiss Round :
    • Swiss round creation with matchs
    • Launch swiss round's matchs by round
    • Launch selected swiss round's matchs
    • Generate subsequent round matchs from previous results
    • Edit matchs :
      • BO type
      • teams
  • Brackets :
    • Brackets creation
      • by hand
      • automaticaly from groups or swiss rounds results
    • Launch matchs by round
    • Launch selected matchs
    • Edit matchs :
      • BO type
      • teams

@istar410 istar410 mentioned this pull request Jan 30, 2025
Open
5 tasks
@istar410 istar410 requested review from KwikKill and floflo0 February 14, 2025 23:11
KwikKill
KwikKill reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on a really good way. Not many comments on either the code or the operation, very good work.

@istar410 istar410 marked this pull request as ready for review February 20, 2025 21:01
@istar410 istar410 requested a review from KwikKill February 20, 2025 21:02
KwikKill
KwikKill approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KwikKill
KwikKill reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good most of the time but for the groups it look strange (stretched)
image

@istar410
first draft for tournament admin views
5835f0c
@istar410
improve admin teams seeding form and add validation
75d7c32
@istar410
improve breakpoints and tournament info dropdown
23fe87e
@istar410
add admin seating path
69be16c
@istar410
add save icon
ea7a5a8
@istar410
fix group teams type to a list of numbers
d7b634c
@istar410
switch from Error to Notification
1642c83
@istar410
finish team seeding update implementation + minor UI fixes
8f7e48c
@istar410
use tournament store to access validated teams in GroupTable
f3d4c48
@istar410
add tiebreak scores
094b68f
@istar410
create AdminGroupTable
6602316
@istar410
can edit group data
36a9dc7
@istar410
update button ui for AdminGroups page
176c788
@istar410
create or delete all groups
6105f8a
@istar410
create or delete all groups matchs
808c86e
@istar410
launch a round of groups matchs
1f30fad
@istar410
add padding around tournament name on TournamentDetail page
a819cc1
@istar410
improve buttons layout on AdminGroups page
c20d69d
@istar410
admin table of group matchs and make them selectable
a6c740d
@istar410
copy the button to launch a round of groups' matchs
e0116a2
istar410 and others added 28 commits February 24, 2025 23:20
@istar410
fix bracket round title computation
9bc2781
@istar410
switch from "round" to "tour"
2e230cb
@istar410
add bracket naming for user page
d1e6825
@istar410
fix bracket launch selected matchs call
0c7f707
@istar410
rework bracket admin buttons UI and delete launch round action
0dad066
@istar410
disable match selection if no teams
3cd2b07
@istar410
fix typos
c18fd3a
@KwikKill @istar410
Fix text width
6c2dd71
@KwikKill @istar410
Move tournament files in dedicated folder.
b1597fb
@KwikKill @istar410
Fix import omission
131b855
@KwikKill @istar410
Fix small margin nitpicks
a77b29d
@istar410
put winning team name in green
849e816
@istar410
admin can edit match status
63e7c4a
@istar410
admin can edit match scores
0f37234
@KwikKill @istar410
Improve AdminMatch UI
5239469
@istar410
UI improvements for AdminMatch
af7a696
@istar410
can specify best of type when creating a bracket
81d47d8
@istar410
fix error when accessing AdminGroupMatchs whitout any groups
7915ed8
@istar410
rework swiss rounds and brackets public interface
524835a
@istar410
fix overflows in AdminMatch
d7c8567
@istar410
use tournament store to access validated teams
4cee294
@istar410
fix uncentered match status in AdminMatch
b60f7c2
@istar410
switch from table to div layout for AdminMatch
d838921
@istar410
change background, switch from border to ring and some spacing adjust…
03a02b2 
…ments
@istar410
improve final winner display
aabe956
@istar410
update AdminMatch ui
f6b0b81
@istar410
restrict access to tournament admin pages
6be6d06
@istar410
improve admin groups' matchs table
9021689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwikKill KwikKill KwikKill approved these changes

@floflo0 floflo0 floflo0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tournament front
3 participants
@istar410 @KwikKill @floflo0