Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #28

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Refactoring #28

wants to merge 10 commits into from

Conversation

aliceboizet
Copy link
Contributor

  • Distinguish local and global reactiveValues (global are in rv and are used in several modules)
  • Renaming rv$data_plot in rv$extradata (seeing that it comes from extradata module)
  • If possible, replace observe() by observeEvent()
  • Remove render functions from observers.
  • Specify used R packages in modules with @import annotation and use attachment::att_amend_desc() to generate DESCRIPTION and NAMESPACE files.
  • use bslib accordion in get_study_data module
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant