-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the topics and services listed in the README #3215
Updated the topics and services listed in the README #3215
Conversation
…ist and ros2 service list, as the previous ones were out of date.
Can one of the admins verify this patch? |
Hi @sysrsbuild @SamerKhshiboun & @Nir-Az, |
Hi @louislelay , Sorry for that probably this fall between our tasks. |
No problem, @Nir-Az! Just following up. Thanks for the quick answer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @louislelay - thanks for your contribution!
Working on the ros2-development branch, I had the following results:
ros2 topic list
/parameter_events
/robot1/D455_1/color/camera_info
/robot1/D455_1/color/image_raw
/robot1/D455_1/color/metadata
/robot1/D455_1/depth/camera_info
/robot1/D455_1/depth/image_rect_raw
/robot1/D455_1/depth/metadata
/robot1/D455_1/extrinsics/depth_to_color
/rosout
/tf_static
ros2 service list
/robot1/D455_1/calib_config_read
/robot1/D455_1/calib_config_write
/robot1/D455_1/describe_parameters
/robot1/D455_1/device_info
/robot1/D455_1/get_parameter_types
/robot1/D455_1/get_parameters
/robot1/D455_1/get_type_description
/robot1/D455_1/hw_reset
/robot1/D455_1/list_parameters
/robot1/D455_1/set_parameters
/robot1/D455_1/set_parameters_atomically
These results are slightly different from yours.
Please tell me if you can check and eventually fix it in your Pull Request.
Thanks!
Hi @remibettan, Thanks for your response! I did a fresh install and verified this on the I have an extra topic that you don’t These differences appear when running: ros2 launch realsense2_camera rs_launch.py camera_namespace:=robot1 camera_name:=D455_1 ros2 node list
/robot1/D455_1 ros2 topic list
/parameter_events
/robot1/D455_1/color/camera_info
/robot1/D455_1/color/image_raw
/robot1/D455_1/color/metadata
/robot1/D455_1/depth/camera_info
/robot1/D455_1/depth/image_rect_raw
/robot1/D455_1/depth/metadata
/robot1/D455_1/extrinsics/depth_to_color
/robot1/D455_1/extrinsics/depth_to_depth
/rosout
/tf_static ros2 service list
/robot1/D455_1/calib_config_read
/robot1/D455_1/calib_config_write
/robot1/D455_1/describe_parameters
/robot1/D455_1/device_info
/robot1/D455_1/get_parameter_types
/robot1/D455_1/get_parameters
/robot1/D455_1/hw_reset
/robot1/D455_1/list_parameters
/robot1/D455_1/set_parameters
/robot1/D455_1/set_parameters_atomically I also verified this using the ros2 run realsense2_camera realsense2_camera_node --ros-args -r __node:=D455_1 -r __ns:=robot1 After investigating, I found that the Additionally, the topics and services differ significantly depending on whether we use Using ros2 node list
/robot1/D455_1 ros2 topic list
/parameter_events
/robot1/D455_1/accel/imu_info
/robot1/D455_1/accel/metadata
/robot1/D455_1/accel/sample
/robot1/D455_1/color/camera_info
/robot1/D455_1/color/image_raw
/robot1/D455_1/color/metadata
/robot1/D455_1/depth/camera_info
/robot1/D455_1/depth/image_rect_raw
/robot1/D455_1/depth/metadata
/robot1/D455_1/extrinsics/depth_to_accel
/robot1/D455_1/extrinsics/depth_to_color
/robot1/D455_1/extrinsics/depth_to_depth
/robot1/D455_1/extrinsics/depth_to_gyro
/robot1/D455_1/extrinsics/depth_to_infra1
/robot1/D455_1/gyro/imu_info
/robot1/D455_1/gyro/metadata
/robot1/D455_1/gyro/sample
/robot1/D455_1/infra1/camera_info
/robot1/D455_1/infra1/image_rect_raw
/robot1/D455_1/infra1/metadata
/rosout
/tf_static ros2 service list
/robot1/D455_1/calib_config_read
/robot1/D455_1/calib_config_write
/robot1/D455_1/describe_parameters
/robot1/D455_1/device_info
/robot1/D455_1/get_parameter_types
/robot1/D455_1/get_parameters
/robot1/D455_1/hw_reset
/robot1/D455_1/list_parameters
/robot1/D455_1/set_parameters
/robot1/D455_1/set_parameters_atomically Would you like me to update my PR to include these observations? Let me know what you think! |
Hi @louislelay - sorry for the delay!
Thanks a lot for your contribution! |
…n ros2 run differences
Hi @remibettan, thanks for your feedback! I’ve updated the README as recommended. Just to clarify—I was also on the development branch for librealsense, not the master branch. So the differences we observed might stem from other factors rather than the branch version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks @louislelay
I updated the topics and services listed in the README file. As when we run ros2 topic list and ros2 service list after launching the sames commands, the previous output displayed were out of date.
This came from conversation we had in the following issue (3208) : #3208