Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update according to changes to Python-ROS 2 API #82

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Update according to changes to Python-ROS 2 API #82

merged 6 commits into from
Feb 1, 2025

Conversation

asaj
Copy link

@asaj asaj commented Nov 10, 2024 •
edited
Loading

Additional followup to #67 and #68

Also some minor fixes including

  • Use rclpy.duration.Duration in place of builtin_interfaces.msg.Duration as the latter does not support addition with Time
  • Strip comments out of robot_description URDF, which cause parsing errors when passed as a param

Fixes #81

lukeschmitt-tr
lukeschmitt-tr requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@lukeschmitt-tr lukeschmitt-tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! Just a few very minor comments here.

interbotix_xs_toolbox/interbotix_xs_modules/interbotix_xs_modules/xs_robot/locobot.py Outdated Show resolved Hide resolved
interbotix_xs_toolbox/interbotix_xs_modules/interbotix_xs_modules/xs_robot/turret.py Outdated Show resolved Hide resolved
@lukeschmitt-tr lukeschmitt-tr linked an issue Nov 12, 2024 that may be closed by this pull request
[Bug]: parser error Couldn't parse parameter override rule: '--param robot_description #81
Closed
@lukeschmitt-tr lukeschmitt-tr mentioned this pull request Jan 24, 2025
Closed
@lukeschmitt-tr lukeschmitt-tr merged commit 28bd7aa into Interbotix:humble Feb 1, 2025
1 check passed
lukeschmitt-tr added a commit that referenced this pull request Feb 1, 2025
@asaj @lukeschmitt-tr
Update according to changes to Python-ROS 2 API (#82)
3d510be 
* strip comments from locobot urdf

* Update according to changes to Python-ROS 2 API

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Update interbotix_xs_toolbox/interbotix_xs_modules/interbotix_xs_modules/xs_launch/xs_launch.py

---------

Co-authored-by: lukeschmitt-tr <[email protected]>
lukeschmitt-tr added a commit that referenced this pull request Feb 1, 2025
@asaj @lukeschmitt-tr
Update according to changes to Python-ROS 2 API (#82)
1c62d1b 
* strip comments from locobot urdf

* Update according to changes to Python-ROS 2 API

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Update interbotix_xs_toolbox/interbotix_xs_modules/interbotix_xs_modules/xs_launch/xs_launch.py

---------

Co-authored-by: lukeschmitt-tr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeschmitt-tr lukeschmitt-tr lukeschmitt-tr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: parser error Couldn't parse parameter override rule: '--param robot_description
2 participants
@asaj @lukeschmitt-tr