Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group comparisons #188

Merged
merged 11 commits into from
Mar 26, 2024

Conversation

phobson
Copy link
Contributor

@phobson phobson commented Mar 23, 2024

So far:

  • made some minor clean ups
  • added infrastructure for general comparison tests (i.e., N > 2 groups)
  • convert some cache'd DataCollection properties to methods so that we can pass options on to scipy.stats.<func>
  • add some F-test and Kruskal-Wallis to DataCollection

Left to do:

  • add Tukey HSD weirdness
  • Add the Dunn test stuff

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 27.48%. Comparing base (d63b8b0) to head (6bf308d).
Report is 2 commits behind head on main.

❗ Current head 6bf308d differs from pull request most recent head c5c793f. Consider uploading reports for the commit c5c793f to get more accurate results

Files Patch % Lines
wqio/datacollections.py 52.63% 18 Missing ⚠️
wqio/features.py 0.00% 4 Missing ⚠️
wqio/viz.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   28.02%   27.48%   -0.54%     
==========================================
  Files          11       11              
  Lines        1895     1899       +4     
  Branches      487      474      -13     
==========================================
- Hits          531      522       -9     
- Misses       1364     1377      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phobson phobson force-pushed the add-group-comparisons branch from fec02f8 to af97add Compare March 25, 2024 23:02
@phobson phobson force-pushed the add-group-comparisons branch from af97add to 9d45fdf Compare March 25, 2024 23:06
@phobson phobson merged commit 18d727e into International-BMP-Database:main Mar 26, 2024
5 checks passed
@phobson phobson deleted the add-group-comparisons branch March 26, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants