CO-2135_Render_MVPA_View_action_with_lightbox #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
from
0daa446 to
0733616
Compare
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
from
0733616 to
5c082bb
Compare
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
10 times, most recently
from
7cb5a2b to
7b2de58
Compare
|
These changes look very good to me. I'm happy to see this merged, so approved from my end - but I also recognize that this solution is blocked by https://todos.internet2.edu/browse/CO-2130 / #213 which should be considered first. |
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
from
7b2de58 to
3529db4
Compare
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
3 times, most recently
from
8550b97 to
340c722
Compare
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
from
340c722 to
fc2ad59
Compare
ioigoume
force-pushed
the
CO-2135_Render_MVPA_View_action_with_lightbox
branch
from
fc2ad59 to
9f59408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render MVPA Views inside a lightbox