CO-1336_Normalization_vs_Pipelines #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioigoume
force-pushed
the
CO-1336_Normalization_vs_Pipelines
branch
2 times, most recently
from
43413b7 to
d61f6ec
Compare
boshrin
requested changes
Jan 13, 2022
There was a problem hiding this comment.
This change appears to define an enumeration in the DefaultNormalizer plugin, and then references that enumeration in the core code (CoPipeline). In general, the core code should not know anything about plugin specifics. This change also breaks the interface for normalizer plugins, which is not something we can do in a minor release.
We should probably discuss this one before proceeding...
ioigoume
force-pushed
the
CO-1336_Normalization_vs_Pipelines
branch
from
d61f6ec to
668b0dc
Compare
ioigoume
force-pushed
the
CO-1336_Normalization_vs_Pipelines
branch
from
668b0dc to
444bf98
Compare
ioigoume
force-pushed
the
CO-1336_Normalization_vs_Pipelines
branch
from
444bf98 to
57030cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not normalize(mixCase) attributes synced to CoPersonRole from OIS