Add TagSet and editor support (#129) #132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potential improvements, let's discuss:
|
Interrupt
reviewed
Oct 14, 2020
| @@ -0,0 +1,10 @@ | |||
| package com.badlogic.gdx.utils; | |||
|
|
|||
| import java.util.HashSet; | |||
There was a problem hiding this comment.
Be warned, the default Java collections are not always great for performance since they sometimes create extra objects when accessed. LibGdx includes some more game-friendly collections, could this be done with something like the libGdx ArrayMap? https://libgdx.badlogicgames.com/ci/nightlies/docs/api/com/badlogic/gdx/utils/ArrayMap.html
There was a problem hiding this comment.
I opted in for the ObjectSet mainly because of the API compatibility, and also because the Set (as opposed to the Map) interface stores only a set of unique keys. There is no use for the values in the tag system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support through the use of a HashSet sub-class, which gets some editor features.