Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate serialiseTxLedgerCddl #772

Closed
wants to merge 2 commits into from

Conversation

palas
Copy link
Contributor

@palas palas commented May 20, 2024

Changelog

- description: |
    Update `cardano-cli` and tests to work with the changes to deprecate `serialiseTxLedgerCddl`
  type:
    - breaking       # the API has changed in a breaking way

Context

cardano-api

cardano-cli

cardano-node

How to trust this PR

Don't trust it. Make sure the changes make sense and that the breakages in compatibility are for the better.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas force-pushed the deprecate-serialiseTxLedgerCddl-testing branch 2 times, most recently from 633a39a to 0b41817 Compare May 28, 2024 19:48
@palas palas force-pushed the deprecate-serialiseTxLedgerCddl-testing branch from 0b41817 to 0196f48 Compare May 28, 2024 19:51
@palas palas changed the title Deprecate serialise tx ledger cddl testing Deprecate serialiseTxLedgerCddl May 29, 2024
@smelc
Copy link
Contributor

smelc commented Jun 13, 2024

Integrated into #786

@smelc
Copy link
Contributor

smelc commented Jun 13, 2024

Closing as it got merged as part of #786

@smelc smelc closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants