Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: governance action votes calculation #2913

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: governance action votes calculation #2913

merged 1 commit into from
Feb 6, 2025

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Feb 6, 2025 •
edited
Loading

List of changes

  • fix: governance action votes calculation

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

Ryun1
Ryun1 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work 💪

@MSzalowski MSzalowski force-pushed the fix/votes-counting-for-governance-actions branch from 3e4e687 to 9fd1f81 Compare February 6, 2025 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/votes-counting-for-governance-actions branch from a94f4c3 to c7dad14 Compare February 6, 2025 15:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

5 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

✅ All checks succeeded

@MSzalowski
Copy link
Contributor Author

That results in:
image
For this governance action:
https://cardanoscan.io/govAction/gov_action133jnaewfsq8x6v08ndd87l2yqryp63r30t2dkceacxx5cply5n7sqzlcyqf

@MSzalowski MSzalowski merged commit cf25899 into develop Feb 6, 2025
3 of 5 checks passed
@MSzalowski MSzalowski deleted the fix/votes-counting-for-governance-actions branch February 6, 2025 15:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

@MSzalowski
This PR is in the tag: develop-cf2589962953617d1d723beb8b5a257e4816b344 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

@MSzalowski
This PR is in the tag: develop-cf2589962953617d1d723beb8b5a257e4816b344 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

@MSzalowski
This PR is in the tag: develop-cf2589962953617d1d723beb8b5a257e4816b344 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSzalowski @Ryun1