Skip to content

Commit

Permalink
Merge pull request #211 from fabiobrz/issues-207.wf-app-config
Browse files Browse the repository at this point in the history
[issues-207] - Fix how Maven additioanl args for s2i OpenSHift builds are built by WildFly related application descriptors
  • Loading branch information
tommaso-borgato authored Jan 9, 2025
2 parents 64c2ed8 + 5e8af07 commit 3eb44c4
Showing 1 changed file with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,22 @@ default String bomsEeServerVersionPropertyName() {
return WILDFLY_BOMS_EE_SERVER_VERSION;
}

/**
* This must match the property name in the pom.xml file used to set the "wildfly-galleon-pack" feature pack GAV
*
* @return property name in the pom.xml file used to set the feature pack GAV
*/
default String featurePackLocationPropertyName() {
return WILDFLY_FEATURE_PACK_LOCATION;
}

/**
* This must match the property name in the pom.xml file used to set the "wildfly-ee-galleon-pack" feature pack GAV
*
* @return property name in the pom.xml file used to set the feature pack GAV
*/
default String eeFeaturePackLocationPropertyName() {
return WILDFLY_FEATURE_PACK_LOCATION;
return WILDFLY_EE_FEATURE_PACK_LOCATION;
}

/**
Expand Down Expand Up @@ -206,7 +215,7 @@ default String generateAdditionalMavenArgs() {
: (" -D" + this.eeFeaturePackLocationPropertyName() + "="
+ this.eeFeaturePackLocation())))
+ ((Strings.isNullOrEmpty(this.featurePackLocation()) ? ""
: (" -D" + this.featurePackLocation() + "="
: (" -D" + this.featurePackLocationPropertyName() + "="
+ this.featurePackLocation())))
+ ((Strings.isNullOrEmpty(this.cloudFeaturePackLocation()) ? ""
: (" -D" + this.cloudFeaturePackLocationPropertyName() + "="
Expand Down

0 comments on commit 3eb44c4

Please sign in to comment.