You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Operator based provisioners do not allow for the package manifest to be configurable, see for instance the Keycloak operator provisioner, where it is hard-coded to rhsso-operator. This way the provisioner fails when trying to provision the community version, because in such a case the right package manifest name would be keycloak-operator.
To Reproduce
mvn clean test -pl testsuite/ -Dtest=KeycloakOperatorProvisionerTest -Dintersmash.keycloak.operators.catalog_source=community-operators
Expected behavior
The Keycloak operator should be provisioned successfully and visible from the WebConsole or through oc
Screenshots
N/A
Additional context
A new Intersmash configuration property should be created for each supported Operator based provisioner, in order to let the users configure the proper package manifest name, depending on whether they want for a community or productized (or even a development/custom) one to be provisioned. This is already done for other parameters in the Operator based provisioning context, i.e. for the catalog source and operator image index, see https://github.com/Intersmash/intersmash/blob/main/tools/intersmash-tools-core/src/main/java/org/jboss/intersmash/tools/IntersmashConfig.java#L38-L49
The solution should be to create a similar property, like e.g.: private static final String KEYCLOAK_OPERATOR_PACKAGE_MANIFEST = "intersmash.keycloak.operators.package_manifest";
Describe the bug
Operator based provisioners do not allow for the package manifest to be configurable, see for instance the Keycloak operator provisioner, where it is hard-coded to
rhsso-operator
. This way the provisioner fails when trying to provision the community version, because in such a case the right package manifest name would bekeycloak-operator
.To Reproduce
mvn clean test -pl testsuite/ -Dtest=KeycloakOperatorProvisionerTest -Dintersmash.keycloak.operators.catalog_source=community-operators
Expected behavior
The Keycloak operator should be provisioned successfully and visible from the WebConsole or through
oc
Screenshots
N/A
Additional context
A new Intersmash configuration property should be created for each supported Operator based provisioner, in order to let the users configure the proper package manifest name, depending on whether they want for a community or productized (or even a development/custom) one to be provisioned. This is already done for other parameters in the Operator based provisioning context, i.e. for the catalog source and operator image index, see https://github.com/Intersmash/intersmash/blob/main/tools/intersmash-tools-core/src/main/java/org/jboss/intersmash/tools/IntersmashConfig.java#L38-L49
The solution should be to create a similar property, like e.g.:
private static final String KEYCLOAK_OPERATOR_PACKAGE_MANIFEST = "intersmash.keycloak.operators.package_manifest";
An alternative would be to migrate the Intersmash Operator based provisioning implementation from using the package manifest format, which is now deprecated, to the new bundle format, but there are unclear points which must be solved firsts, and we need a short time solution as well. See https://docs.openshift.com/container-platform/4.12/operators/operator_sdk/osdk-pkgman-to-bundle.html - Tracked as Evaluate migrating the Operator based provisioners implementation from the deprecated packageManifest to alternative and supported formats #24
The text was updated successfully, but these errors were encountered: