Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 23] - Operator provisioning configurable package manifest #25

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Apr 14, 2023

Description

This PR implements the changes requested by #23 so that a Operator based provisioner package manifest can be configurable.

Here we also enable InfinispanOperatorProvisionerTest(as part of #21) to verify the changes.

Fix #23

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz changed the title Operator provisioning.configurable package manifest Operator provisioning configurable package manifest Apr 14, 2023
@fabiobrz fabiobrz requested a review from simkam April 14, 2023 15:28
@fabiobrz fabiobrz marked this pull request as draft April 14, 2023 15:52
@fabiobrz fabiobrz force-pushed the operator-provisioning.configurable-package-manifest branch from 3a4577b to db3a4db Compare April 15, 2023 16:27
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

2 similar comments
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz fabiobrz force-pushed the operator-provisioning.configurable-package-manifest branch from d5ab6c0 to 10e90df Compare April 15, 2023 17:05
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

1 similar comment
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

…ed test to verify package manifest configuration
…CI checks on OpenShift CI infra to avoid using the temporary oc.config file and make the oc binary calls succeed
…e, password and token) as the values for the xtf.openshift.admin.* and xtf.openshift.master.* properties, so that kubeconfig is used by oc binary in XTF
@fabiobrz fabiobrz marked this pull request as ready for review April 16, 2023 10:18
@fabiobrz fabiobrz force-pushed the operator-provisioning.configurable-package-manifest branch from 6b68e1f to 5088066 Compare April 16, 2023 10:19
@fabiobrz fabiobrz changed the title Operator provisioning configurable package manifest [issue 23] - Operator provisioning configurable package manifest Apr 17, 2023
@simkam simkam merged commit d8a5cbc into Intersmash:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package manifest name is hard-coded in Operator based provisioners
2 participants