Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application descriptor documentation to README #120

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Dec 14, 2023

Description

Adding the Application descriptor building block documentation to the main README file

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz fabiobrz requested a review from rsearls December 15, 2023 10:08
rsearls and others added 2 commits December 18, 2023 11:13
Add application descriptor documentation to README - proposed edits
@fabiobrz
Copy link
Member Author

Hi @rsearls - do we need anything else here?

@rsearls
Copy link
Collaborator

rsearls commented Dec 18, 2023

I don't think so.

@fabiobrz fabiobrz merged commit 02bc828 into Intersmash:main Dec 19, 2023
3 checks passed
@fabiobrz
Copy link
Member Author

Ok thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants