Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue 123] - Implement WildFly/EAP 8 Helm Charts provisioning differentiation #124

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[issue 123] - Implement WildFly/EAP 8 Helm Charts provisioning differentiation #124

merged 2 commits into from
Jan 10, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Dec 19, 2023 •
edited
Loading

Description

Backporting existing internal implementation

Fix #123

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz force-pushed the separate-eap8-wildfly-helm-charts branch 2 times, most recently from 600480d to e341df9 Compare December 20, 2023 11:40
@fabiobrz fabiobrz force-pushed the separate-eap8-wildfly-helm-charts branch 2 times, most recently from 84fb778 to 63a69fc Compare December 22, 2023 08:12
tommaso-borgato
tommaso-borgato approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@tommaso-borgato tommaso-borgato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a couple of comments mostly about channels and their integration, which might be done in #125

.../intersmash/testsuite/provision/openshift/WildflyHelmChartExistingValuesProvisionerTest.java Outdated Show resolved Hide resolved
...ss/intersmash/testsuite/provision/openshift/WildflyHelmChartOpenShiftExampleApplication.java Show resolved Hide resolved
...testsuite/provision/openshift/WildflyHelmChartExistingValuesOpenShiftExampleApplication.java Outdated Show resolved Hide resolved
tools/intersmash-tools-provisioners/pom.xml Show resolved Hide resolved
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz fabiobrz force-pushed the separate-eap8-wildfly-helm-charts branch from 63a69fc to aa33d54 Compare January 7, 2024 17:26
@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 7, 2024

/retest

@fabiobrz fabiobrz force-pushed the separate-eap8-wildfly-helm-charts branch from aa33d54 to 3de6cf7 Compare January 9, 2024 06:29
@fabiobrz fabiobrz force-pushed the separate-eap8-wildfly-helm-charts branch from 3de6cf7 to 690c905 Compare January 10, 2024 12:24
@fabiobrz
Copy link
Member Author

/retest

@tommaso-borgato tommaso-borgato merged commit ef18d96 into Intersmash:main Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommaso-borgato tommaso-borgato tommaso-borgato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiate WildFly and EAP 8 Helm Charts provisioning
2 participants
@fabiobrz @tommaso-borgato