-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue 113] - Refactor deployments, tools and remove legacy name identifiers #129
[issue 113] - Refactor deployments, tools and remove legacy name identifiers #129
Conversation
0618584
to
f926046
Compare
21bc635
to
127bd62
Compare
/retest |
1 similar comment
/retest |
5fdfe98
to
c3ee0ce
Compare
0ec4e58
to
44c5656
Compare
0b34ea9
to
01616b0
Compare
...nts-provider/src/main/java/org/jboss/intersmash/deployments/IntersmashSharedDeployments.java
Outdated
Show resolved
Hide resolved
AFAICS |
I go through the current commits and just find a few minor issues. Please also let me know once CI would be fixed or share some details about the test errors. Thank you for this MR! |
01616b0
to
76ad573
Compare
…ployment to only support product (EAP 7). Renaming/refactoring tests components that are related to the EAP 7 Bootable JAR provisioning
76ad573
to
0dcb844
Compare
Thanks @marekkopecky - I removed one of them which was redundant. The others are meant to be there for the following reasons:
|
…ming packages and demos
0dcb844
to
9ac515e
Compare
Thanks a lot for your review @marekkopecky - let's see whether the last run fixes the only failure (which I was not able to reproduce at first attempt locally), otherwise I'll try and work on it it later or on Monday. |
Yes, this is true. Theoretically we could probably have one example for WF and second one for EAP, so there might be a need for this. This said, the versions are the same now in both examples. Let's keep it as it is, but if we find out that there won't be any need for different versions, we can move the version property to examples/pom.xml |
/retest |
6dae517
to
71dade1
Compare
Fix tests after moving core and provisioners
…nd excluding Bootable JAR tests when testing EAP
71dade1
to
00ac6ee
Compare
Hi @marekkopecky - I fixed the last tests and CI checks are green now. Let me know whether you think there's something else we'd want to do here. |
Thank you! PR merged. |
Description
core
andprovisioners
are top levelFix #113
Note for reviewer(s)
A lot of files have been changed but don't be scared, this PR is basically and mostly about renaming files. Just a few minor changes have been added to those, but here's a per-commit recap to make your work quicker:
1. Mainly renaming files.
A POM configuration has been added since it was missing in the EAP logic so far. Code cleaning.
2. Fixing WIldFLy/EAP XP BOMs definitions
3. BIG move
Basically moved files + consequent package name refactoring affecting imports + CI update
testsuite modles split in deployments + integration-tests.
Renamed demos to examples as well (sorry)
BTW broken commit containing an unresolved conflict
4. Just fixing examples modules imports
5. BIG move
Basically moved files + consequent package name refactoring affecting imports + CI update
6. Fixing the Bootable JAR plugin configuration after moving core and provisioners up, and removing a redundant lombok dep
7. Fixing the CI scripts again and a SPI registration file containing a wrong package
8. Renaming the profile for configuring the excluded tests depending on TS execution target (community/prod)
Renaming the profile for configuring the excluded tests depending on wildfly/eap target version (eap/eapxp)
9. the e2e scripts need to set
intersmash.deployments.repository.url
andintersmash.deployments.repository.ref
to those of the PR, otherwise deployments are cloned from the Intersmash repo itself, and this doesn't work when modifying a deployment.Type of change
test, version modification, documentation, etc.)
Checklist