Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue 136] - Adding a specific e2e script for the OpenShift CI periodic prow job (and minor fixes/cleanup) #137

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[issue 136] - Adding a specific e2e script for the OpenShift CI periodic prow job (and minor fixes/cleanup) #137

merged 1 commit into from
Feb 5, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Feb 2, 2024

Description

Fix #136

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

fabiobrz commented Feb 2, 2024

Once openshift/release#48388 is merged and CI checks are green here, we can merge this safely.

@fabiobrz
Copy link
Member Author

fabiobrz commented Feb 2, 2024

/retest

2 similar comments
@fabiobrz
Copy link
Member Author

fabiobrz commented Feb 2, 2024

/retest

@fabiobrz
Copy link
Member Author

fabiobrz commented Feb 3, 2024

/retest

tommaso-borgato
tommaso-borgato approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@tommaso-borgato tommaso-borgato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: basically the periodic job doesn't use PR author because there is no PR in periodic job....

@tommaso-borgato tommaso-borgato merged commit 3fb1e78 into Intersmash:main Feb 5, 2024
3 checks passed
@tommaso-borgato
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommaso-borgato tommaso-borgato tommaso-borgato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The OpenShift CI e2e periodic Prow job is failing
2 participants
@fabiobrz @tommaso-borgato