Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Helm chart release adapter for EAP XP 5 #181

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

honza-kasik
Copy link
Contributor

@honza-kasik honza-kasik commented Jul 18, 2024

Description

Added Helm chart release adapter for EAP XP 5, also added build mode manipulation methods to other Helm chart release adapters.

Closes #179

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@honza-kasik honza-kasik marked this pull request as draft July 18, 2024 11:01
Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @honza-kasik - and thanks for this great contribution to Intersmash.
I dropped just a couple of comments - although the PR is still being a draft.
Feel free to let me know what you think.

@honza-kasik honza-kasik changed the title Draft: Added Helm chart release adapter for EAP XP 5 Added Helm chart release adapter for EAP XP 5 Jul 19, 2024
@honza-kasik honza-kasik marked this pull request as ready for review July 19, 2024 07:30
@fabiobrz fabiobrz closed this Jul 19, 2024
@fabiobrz fabiobrz reopened this Jul 19, 2024
@fabiobrz
Copy link
Member

Thanks for addressing my comments, @honza-kasik

Internal CI validation runs show identical failures between this PR branch and main, which will be tracked separately:

  • Infinispan issues are due to deprecated APIs in 8.5.0
  • Issues affecting the legacy RH-SSO Operator provisioning tooling (which is deprecated already in Intersmash) are most likely due to changes to the Operator channel names.
  • The remaining issues with WildFly provisioners, which in this case are used for XP deployments, are most likely not working due to the fact that a POM property is not set, neither propagated to OpenShift s2i builds in the XP 5 case.

With all that being said, I am approving your changes, which LGTM, and merging this PR into main.
Thanks again for adding features to Intersmash!

@fabiobrz fabiobrz merged commit 6aa21fc into Intersmash:main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an Helm Chart release adapter for EAP XP 5
2 participants