Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-219] - Support ActiveMQ Artemis 2.3.8/AMQ Broker 7.12.x #220

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

fabiobrz
Copy link
Member

SSIA

Resolves #219

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

/test

1 similar comment
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #220 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#167> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#99> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap#98> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#105> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #220 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#168> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#100> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#106> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #220 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#168> FAILED:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#100_> reported failures.

Test Result (1 failure / -2)

  • org.jboss.intersmash.testsuite.provision.auto.AutoProvisioningTests.testAppIsLive

Random and not related to changes, and it passes in a parallel run (i.e. <eap-8.x-intersmash-integration-tests-community#99>) ✅

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#106_> reported failures.

This is a failure that is getting more and more regular just in the EAP XP related executtion. Should be tracked differnetly but the subscription logic is working since all other operator related tests passed. ✅

  Please verify your changes locally or reach out to maintainers in order to investigate the issues.

Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

@marekkopecky
Copy link
Collaborator

Thank you for this PR, LGTM, merging.

@marekkopecky marekkopecky merged commit c0b56bd into Intersmash:main Jan 14, 2025
2 checks passed
@fabiobrz
Copy link
Member Author

Thank you for this PR, LGTM, merging.

Wow, this was quick! Thanks @marekkopecky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support latest ActiveMQ Artemis/AMQ Broker
2 participants