Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 21] - Enable kafka operator provisioner test #35

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Apr 26, 2023

Description

Here we enable the KafkaOperatorProvisionerTest as part of #21 .

The Kafka operator based provisioning tooling relies on the Kafka community operator which is provided by Strimzi. The latest version of Strimzi would be 0.34 but it doesn't seem to work, at least when experimenting locally, because of some troubles when downloading the library artifact.

This is the reason why we set the supported version of Strimzi to be 0.29.0 while it would be 3.2.0 for the operated Kafka and let this test to be enabled, while the effort required to support the latest Kafka is tracked by #34

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fabiobrz
Copy link
Member Author

/test all

@fabiobrz fabiobrz marked this pull request as ready for review April 26, 2023 16:40
@fabiobrz fabiobrz force-pushed the enable-kafka-operator-provisioner-test branch from c232220 to 54e5a05 Compare April 26, 2023 16:40
@fabiobrz
Copy link
Member Author

/retest-required

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

1 similar comment
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz fabiobrz requested a review from simkam April 27, 2023 06:56
@simkam
Copy link
Collaborator

simkam commented Apr 27, 2023

@fabiobrz I'm a little bit confused by the description. There is

HyperfoilOperatorProvisionerTest

but I can't see any change to this test.

@fabiobrz
Copy link
Member Author

@fabiobrz I'm a little bit confused by the description. There is

HyperfoilOperatorProvisionerTest

but I can't see any change to this test.

Hi @simkam - sorry, my bad 🤦‍♂️
I've been juggling a bit with both lately, and I got confused or copy/pasted the wrong test class name.
Should be fixed now.

@fabiobrz fabiobrz changed the title Enable kafka operator provisioner test [issue 21] - Enable kafka operator provisioner test Apr 27, 2023
README.md Show resolved Hide resolved
Copy link
Collaborator

@simkam simkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart README question Jan pointed out it LGTM

@simkam simkam merged commit 4bd87e6 into Intersmash:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants