Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 21] - Enabling WildFly Helm Charts based provisioning test #46

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented May 11, 2023

Description

Enabling WildflyHelmChartProvisionerTest

Part of #21

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fabiobrz fabiobrz force-pushed the testsuite.enabling-wildfly-helm-test branch 2 times, most recently from 42b21eb to 472b9e9 Compare May 15, 2023 12:58
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz fabiobrz marked this pull request as ready for review May 15, 2023 15:54
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz
Copy link
Member Author

/retest

.ci/openshift-ci/build-root/e2e-test.sh Show resolved Hide resolved

# Wildfly Helm Charts
intersmash.wildfly.helm.charts.repo=https://github.com/wildfly/wildfly-charts.git
intersmash.wildfly.helm.charts.branch=main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiobrz just upstream latest? why not some tag for stability's sake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right. I'll ask

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say that I'd prefer latest to reduce maintenance...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the version holding the latest tag (wildfly-2.3.2) actually because I think it's better to freeze such version defaults in order to have a detailed knowledge of what we tested against and support.

@fabiobrz fabiobrz force-pushed the testsuite.enabling-wildfly-helm-test branch from 2485573 to 8273869 Compare May 19, 2023 14:40
fabiobrz added 3 commits May 19, 2023 16:41
…xing the CI script to create users (master user is cluster-admin as well, because of failures in InfinispanOperatorProvisionerTest

Removing project creation that is handled by the ProjectCreator XTF extension
…ing the wildfly-2.3.2 default value as for the WildFly Helm CHarts repository tag configuration
@fabiobrz fabiobrz force-pushed the testsuite.enabling-wildfly-helm-test branch from 8273869 to 54a336e Compare May 19, 2023 14:44
@tommaso-borgato tommaso-borgato merged commit c391802 into Intersmash:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants