Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the WildflyTargetServerTestCase #50

Merged

Conversation

fabiobrz
Copy link
Member

Description

Here we enable the WildflyTargetServerTestCase which uses a WildflyImageOpenShiftApplication provisioned by a WildflyImageOpenShiftProvisioner, similarly to what WildflyImageProvisionerTestCase does but using a pre-built deployment instead of a Git repo as the source for the s2i process.

Part of #21

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fabiobrz
Copy link
Member Author

/test all

@fabiobrz fabiobrz marked this pull request as ready for review May 19, 2023 13:38
@tommaso-borgato tommaso-borgato self-assigned this May 19, 2023
@tommaso-borgato tommaso-borgato merged commit 76f0112 into Intersmash:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants