Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/Intersmash/intersmash/issues/37 #57

Merged
merged 11 commits into from
Jun 9, 2023

Conversation

tommaso-borgato
Copy link
Collaborator

@tommaso-borgato tommaso-borgato commented May 23, 2023

Fix #37 and part of #21

This MR contains:

  • new provisioner for the new Quarkus based Keycloak Operator
  • improvement to the PostreSQL image provisioner which is now capable of storing and consuming credentials from a secret that other applications can use to connect to the database (this was needed to provide integration with the new Quarkus based Keycloak Operator)

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tommaso-borgato - thanks for this PR, great job.
I'd have a couple of comments but we should remove the duplication due to the ongoing changes to XTF.
Could you please use the XTF version that I just released, remove duplicated classes and rebase?

@tommaso-borgato tommaso-borgato changed the title DRAFT: Fix https://github.com/Intersmash/intersmash/issues/37 Fix https://github.com/Intersmash/intersmash/issues/37 May 31, 2023
@tommaso-borgato
Copy link
Collaborator Author

@fabiobrz I think we can merge now...

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tommaso-borgato and thanls for this PR introducing the new operator.
Great job! I added my comments, most of them being just minor fixes, I'd say.

BTW - could you please add the documentation for this new provisioner to the README and update this PR title?

@tommaso-borgato
Copy link
Collaborator Author

@fabiobrz thank you for your review! I answered all your questions, perhaps some answers might have some followup on your side....

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments @tommaso-borgato !

I resolved many of them and dropped questions about the ones we still need to clarify.
That being said, great job. We only need to fix the provisioner test(s). 🙂

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your work on this PR, @tommaso-borgato - changes LGTM, approving and merging!

BTW - re https://github.com/Intersmash/intersmash/pull/57/files#r1223062806 - let's file an issue as soon as you have some time.

@fabiobrz fabiobrz merged commit d5670c8 into Intersmash:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate what kind of Keycloak operator should be supported
2 participants