Jaxws bootable jar test

[rsearls]

Description

A jaxws test example
(fix #82)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• Pull Request contains a description of the changes
• Pull Request does not include fixes for multiple issues/topics
• Code is self-descriptive and/or documented
• I have implemented unit tests to cover my changes
• I tested my code in OpenShift

[openshift-ci]

Hi @rsearls. Thanks for your PR.

I'm waiting for a Intersmash member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabiobrz]

/ok-to-test

[fabiobrz]

Thanks for this PR @rsearls! It's great that you started the demos module!

Since we want to bring in the examples incrementally, I'd start with just the jaxws test, and remove the following:

• all the changes to the testsuite module
• all the changes to the tools module
• the whole demos/legacy-wildfly-shrinkwrap-examplemodule
• the ws-bootable-jar-example/jaxrs module
• the demos/ws-bootable-jar-example/ws-bootable-jar-example.iml file

BTW the testsuite/pom.xml conflict will disappear once the first bullet above is done.
I'll review the other parts meanwhile.

[fabiobrz]

Hi @rsearls - I see you moved the test app deployment under the deployments module.
I know we talked about this, but I'd like to share some thoughts regarding this: if this is a PoC - as it seems to me by looking at the very basic test - then there's no need to move the application code to a new deployment into the deployments module
On the other side, I have some ideas on where to place actual Intersmash tests, and I'd like to discuss this with you - provided you don't have a place where to place your team tests already.

So please, keep the demos module, and please follow my hints here.

[fabiobrz]

Hi @rsearls - I had another round of review and I think we're moving in the right direction. I dropped some comments.

[fabiobrz]

/test intersmash-e2e

[fabiobrz]

Hi @rsearls and thanks for addressing my comments.

It seems we're on the right way and almost done! I've replied to a couple of comments and suggested some changes, which BTW I've experimented a bit with, and that you can preview here.

Also, feel free to squash your commits so that we've got less changes when merging.

[fabiobrz]

Hi @rsearls - I've noticed that wildfly bits were not bumped, so I added one commit to my topic branch for doing that, see fabiobrz@02725cd

[rsearls]

@fabiobrz
I've reviewed the CI msgs for this failure. The test is failing with a
cz.xtf.core.waiting.WaiterException

[2023-09-27 19:59:22,032] INFO - Waiting up to 1 minute. Reason: Cleaning project - intersmash-com
[2023-09-27 20:00:23,224] INFO - Cleaning namespace: intersmash-com - timed out.
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 62.611 s <<< FAILURE! - in org.jboss.intersmash.testsuite.provision.openshift.WildflyBootableJarTestCase
[ERROR] org.jboss.intersmash.testsuite.provision.openshift.WildflyBootableJarTestCase Time elapsed: 62.611 s <<< ERROR!
cz.xtf.core.waiting.WaiterException: Cleaning project - intersmash-com
at cz.xtf.core.waiting.SimpleWaiter.waitFor(SimpleWaiter.java:166)
at cz.xtf.junit5.extensions.CleanBeforeAllCallback.beforeAll(CleanBeforeAllCallback.java:12)

I've reviewed the code in WildflyBootableJarTestCase and its dependencies.
I have make no changes to this or related classes.
I have not found this test referencing any code related to demos.
In testsuite/pom.xml there were 2 dependency ref additions, jakarta.servlet-api
and jakarta.inject-api. Test WildflyBootableJarTestCase is not referencing code
in either of these archives.

Perhaps the wait time for cleanup should be extended.

[fabiobrz]

/test prod-intersmash-e2e-prod

[fabiobrz]

All Green now @rsearls, great job!
Could you please squash your commits, so we can move on and merge?

[rsearls]

Squash complete

[fabiobrz]

/test all

[fabiobrz]

/test all

[fabiobrz]

Thanks @rsearls for contrbuting the first Intersmash demo! 😃
Changes LGTM, and I'll merge them as soon as you fill in the boxes in the description!

[rsearls]

done