Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue 67] - Fixing leftover from #94, i.e. enable the Keycloak Realm Import test #97

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[issue 67] - Fixing leftover from #94, i.e. enable the Keycloak Realm Import test #97

merged 3 commits into from
Oct 13, 2023

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Oct 3, 2023 •
edited
Loading

Description

Fixing leftover from #94, i.e. enable the Keycloak Realm Import (the "new one") Operator provisioner test

Part of #67

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

fabiobrz commented Oct 4, 2023

/retest

@fabiobrz fabiobrz force-pushed the fix.enable-keycloak-test branch from 45f9bfe to c7f2a9b Compare October 4, 2023 10:23
@fabiobrz fabiobrz requested a review from marekkopecky October 4, 2023 14:26
@marekkopecky
Copy link
Collaborator

#94 was checked by @tommaso-borgato

@tommaso-borgato can you please check this PR as well?

@marekkopecky marekkopecky requested review from tommaso-borgato and removed request for marekkopecky October 5, 2023 05:27
@tommaso-borgato tommaso-borgato merged commit 6dc3b4a into Intersmash:main Oct 13, 2023
@fabiobrz fabiobrz mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommaso-borgato tommaso-borgato tommaso-borgato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabiobrz @marekkopecky @tommaso-borgato