-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/clones #5
Fix/clones #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smoke_perf_with_zero
test still failing.
I increased success margin for |
if fails with a timeout if building with |
This removes almost all the clones, changes NodeId to size, etc.
As the result, performance improves 4-8 times, and memory usage is reduced 2+ size.
Note that OUT4-based test ("long") was found to be broken: the original input file misplaced some values sometimes.
However, OUT3 (short) test passes now correctly.