Enable strip meta option in global driver config

Intervention · Jan 18, 2025 · 5bfcb52 · 5bfcb52
1 parent d01b2ab
commit 5bfcb52
Show file tree

Hide file tree

Showing 22 changed files with 55 additions and 18 deletions.
diff --git a/src/Config.php b/src/Config.php
@@ -14,13 +14,16 @@ class Config
      * @param bool $autoOrientation
      * @param bool $decodeAnimation
      * @param mixed $blendingColor
+     * @param bool $strip
      * @return void
      */
     public function __construct(
         public bool $autoOrientation = true,
         public bool $decodeAnimation = true,
         public mixed $blendingColor = 'ffffff',
+        public bool $strip = false,
     ) {
+        //
     }
 
     /**

diff --git a/src/Drivers/Imagick/Encoders/AvifEncoder.php b/src/Drivers/Imagick/Encoders/AvifEncoder.php
@@ -19,7 +19,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
         $format = 'AVIF';
         $compression = Imagick::COMPRESSION_ZIP;
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Drivers/Imagick/Encoders/HeicEncoder.php b/src/Drivers/Imagick/Encoders/HeicEncoder.php
@@ -17,7 +17,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
     {
         $format = 'HEIC';
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Drivers/Imagick/Encoders/Jpeg2000Encoder.php b/src/Drivers/Imagick/Encoders/Jpeg2000Encoder.php
@@ -19,7 +19,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
         $format = 'JP2';
         $compression = Imagick::COMPRESSION_JPEG;
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Drivers/Imagick/Encoders/JpegEncoder.php b/src/Drivers/Imagick/Encoders/JpegEncoder.php
@@ -31,7 +31,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
         // possible full transparent colors as black
         $background->setColorValue(Imagick::COLOR_ALPHA, 1);
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Drivers/Imagick/Encoders/TiffEncoder.php b/src/Drivers/Imagick/Encoders/TiffEncoder.php
@@ -17,7 +17,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
     {
         $format = 'TIFF';
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Drivers/Imagick/Encoders/WebpEncoder.php b/src/Drivers/Imagick/Encoders/WebpEncoder.php
@@ -20,7 +20,8 @@ public function encode(ImageInterface $image): EncodedImageInterface
         $format = 'WEBP';
         $compression = Imagick::COMPRESSION_ZIP;
 
-        if ($this->strip) {
+        // strip meta data
+        if ($this->strip || (is_null($this->strip) && $this->driver()->config()->strip)) {
             $image->modify(new StripMetaModifier());
         }
 

diff --git a/src/Encoders/AvifEncoder.php b/src/Encoders/AvifEncoder.php
@@ -12,12 +12,13 @@ class AvifEncoder extends SpecializableEncoder
      * Create new encoder object
      *
      * @param int $quality
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
+        //
     }
 }
diff --git a/src/Encoders/BmpEncoder.php b/src/Encoders/BmpEncoder.php
@@ -10,5 +10,6 @@ class BmpEncoder extends SpecializableEncoder
 {
     public function __construct()
     {
+        //
     }
 }
diff --git a/src/Encoders/GifEncoder.php b/src/Encoders/GifEncoder.php
@@ -16,5 +16,6 @@ class GifEncoder extends SpecializableEncoder
      */
     public function __construct(public bool $interlaced = false)
     {
+        //
     }
 }
diff --git a/src/Encoders/HeicEncoder.php b/src/Encoders/HeicEncoder.php
@@ -12,12 +12,13 @@ class HeicEncoder extends SpecializableEncoder
      * Create new encoder object
      *
      * @param int $quality
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
+        //
     }
 }
diff --git a/src/Encoders/Jpeg2000Encoder.php b/src/Encoders/Jpeg2000Encoder.php
@@ -12,12 +12,13 @@ class Jpeg2000Encoder extends SpecializableEncoder
      * Create new encoder object
      *
      * @param int $quality
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
+        //
     }
 }
diff --git a/src/Encoders/JpegEncoder.php b/src/Encoders/JpegEncoder.php
@@ -13,13 +13,14 @@ class JpegEncoder extends SpecializableEncoder
      *
      * @param int $quality
      * @param bool $progressive
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
         public bool $progressive = false,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
+        //
     }
 }
diff --git a/src/Encoders/PngEncoder.php b/src/Encoders/PngEncoder.php
@@ -17,5 +17,6 @@ class PngEncoder extends SpecializableEncoder
      */
     public function __construct(public bool $interlaced = false, public bool $indexed = false)
     {
+        //
     }
 }
diff --git a/src/Encoders/TiffEncoder.php b/src/Encoders/TiffEncoder.php
@@ -12,12 +12,13 @@ class TiffEncoder extends SpecializableEncoder
      * Create new encoder object
      *
      * @param int $quality
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
+        //
     }
 }
diff --git a/src/Encoders/WebpEncoder.php b/src/Encoders/WebpEncoder.php
@@ -12,12 +12,12 @@ class WebpEncoder extends SpecializableEncoder
      * Create new encoder object
      *
      * @param int $quality
-     * @param bool $strip
+     * @param null|bool $strip
      * @return void
      */
     public function __construct(
         public int $quality = self::DEFAULT_QUALITY,
-        public bool $strip = false
+        public ?bool $strip = null
     ) {
     }
 }
diff --git a/tests/Unit/ConfigTest.php b/tests/Unit/ConfigTest.php
@@ -24,11 +24,13 @@ public function testConstructor(): void
             autoOrientation: false,
             decodeAnimation: false,
             blendingColor: 'f00',
+            strip: true,
         );
         $this->assertInstanceOf(Config::class, $config);
 
         $this->assertFalse($config->autoOrientation);
         $this->assertFalse($config->decodeAnimation);
+        $this->assertTrue($config->strip);
         $this->assertEquals('f00', $config->blendingColor);
     }
 
@@ -37,12 +39,14 @@ public function testGetSetOptions(): void
         $config = new Config();
         $this->assertTrue($config->autoOrientation);
         $this->assertTrue($config->decodeAnimation);
+        $this->assertFalse($config->strip);
         $this->assertEquals('ffffff', $config->blendingColor);
 
         $result = $config->setOptions(
             autoOrientation: false,
             decodeAnimation: false,
             blendingColor: 'f00',
+            strip: true,
         );
 
         $this->assertFalse($config->autoOrientation);
@@ -51,16 +55,19 @@ public function testGetSetOptions(): void
 
         $this->assertFalse($result->autoOrientation);
         $this->assertFalse($result->decodeAnimation);
+        $this->assertTrue($result->strip);
         $this->assertEquals('f00', $result->blendingColor);
 
         $result = $config->setOptions(blendingColor: '000');
 
         $this->assertFalse($config->autoOrientation);
         $this->assertFalse($config->decodeAnimation);
+        $this->assertTrue($config->strip);
         $this->assertEquals('000', $config->blendingColor);
 
         $this->assertFalse($result->autoOrientation);
         $this->assertFalse($result->decodeAnimation);
+        $this->assertTrue($result->strip);
         $this->assertEquals('000', $result->blendingColor);
     }
 
@@ -71,13 +78,16 @@ public function testSetOptionsWithArray(): void
             'autoOrientation' => false,
             'decodeAnimation' => false,
             'blendingColor' => 'f00',
+            'strip' => true,
         ]);
 
         $this->assertFalse($config->autoOrientation);
         $this->assertFalse($config->decodeAnimation);
+        $this->assertTrue($config->strip);
         $this->assertEquals('f00', $config->blendingColor);
         $this->assertFalse($result->autoOrientation);
         $this->assertFalse($result->decodeAnimation);
+        $this->assertTrue($result->strip);
         $this->assertEquals('f00', $result->blendingColor);
     }
 }
diff --git a/tests/Unit/Drivers/Imagick/Encoders/AvifEncoderTest.php b/tests/Unit/Drivers/Imagick/Encoders/AvifEncoderTest.php
@@ -4,6 +4,7 @@
 
 namespace Intervention\Image\Tests\Unit\Drivers\Imagick\Encoders;
 
+use Intervention\Image\Drivers\Imagick\Driver;
 use Intervention\Image\Drivers\Imagick\Encoders\AvifEncoder;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -17,6 +18,7 @@ public function testEncode(): void
     {
         $image = $this->createTestImage(3, 2);
         $encoder = new AvifEncoder(10);
+        $encoder->setDriver(new Driver());
         $result = $encoder->encode($image);
         $this->assertMediaType('image/avif', $result);
         $this->assertEquals('image/avif', $result->mimetype());

diff --git a/tests/Unit/Drivers/Imagick/Encoders/HeicEncoderTest.php b/tests/Unit/Drivers/Imagick/Encoders/HeicEncoderTest.php
@@ -4,6 +4,7 @@
 
 namespace Intervention\Image\Tests\Unit\Drivers\Imagick\Encoders;
 
+use Intervention\Image\Drivers\Imagick\Driver;
 use Intervention\Image\Drivers\Imagick\Encoders\HeicEncoder;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -17,6 +18,7 @@ public function testEncode(): void
     {
         $image = $this->createTestImage(3, 2);
         $encoder = new HeicEncoder(75);
+        $encoder->setDriver(new Driver());
         $result = $encoder->encode($image);
         $this->assertMediaType('image/heic', $result);
         $this->assertEquals('image/heic', $result->mimetype());

diff --git a/tests/Unit/Drivers/Imagick/Encoders/Jpeg2000EncoderTest.php b/tests/Unit/Drivers/Imagick/Encoders/Jpeg2000EncoderTest.php
@@ -4,6 +4,7 @@
 
 namespace Intervention\Image\Tests\Unit\Drivers\Imagick\Encoders;
 
+use Intervention\Image\Drivers\Imagick\Driver;
 use Intervention\Image\Drivers\Imagick\Encoders\Jpeg2000Encoder;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -17,6 +18,7 @@ public function testEncode(): void
     {
         $image = $this->createTestImage(3, 2);
         $encoder = new Jpeg2000Encoder(75);
+        $encoder->setDriver(new Driver());
         $result = $encoder->encode($image);
         $this->assertMediaType('image/jp2', $result);
         $this->assertEquals('image/jp2', $result->mimetype());

diff --git a/tests/Unit/Drivers/Imagick/Encoders/TiffEncoderTest.php b/tests/Unit/Drivers/Imagick/Encoders/TiffEncoderTest.php
@@ -4,6 +4,7 @@
 
 namespace Intervention\Image\Tests\Unit\Drivers\Imagick\Encoders;
 
+use Intervention\Image\Drivers\Imagick\Driver;
 use Intervention\Image\Drivers\Imagick\Encoders\TiffEncoder;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -17,6 +18,7 @@ public function testEncode(): void
     {
         $image = $this->createTestImage(3, 2);
         $encoder = new TiffEncoder();
+        $encoder->setDriver(new Driver());
         $result = $encoder->encode($image);
         $this->assertMediaType('image/tiff', $result);
         $this->assertEquals('image/tiff', $result->mimetype());

diff --git a/tests/Unit/Drivers/Imagick/Encoders/WebpEncoderTest.php b/tests/Unit/Drivers/Imagick/Encoders/WebpEncoderTest.php
@@ -4,6 +4,7 @@
 
 namespace Intervention\Image\Tests\Unit\Drivers\Imagick\Encoders;
 
+use Intervention\Image\Drivers\Imagick\Driver;
 use Intervention\Image\Drivers\Imagick\Encoders\WebpEncoder;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
@@ -17,6 +18,7 @@ public function testEncode(): void
     {
         $image = $this->createTestImage(3, 2);
         $encoder = new WebpEncoder(75);
+        $encoder->setDriver(new Driver());
         $result = $encoder->encode($image);
         $this->assertMediaType('image/webp', $result);
         $this->assertEquals('image/webp', $result->mimetype());
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,5 +10,6 @@ class BmpEncoder extends SpecializableEncoder @@
     {
         public function __construct()
         {
+            //
         }
     }