-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed case if user removes all cycles #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read more about this #178 and this #155 .
Firstly, the previous solution did not fix the bug. Below I will describe the steps.
Secondly, you need to leave checking future cycles and editing the current period. The user must be able to edit the current cycle. I missed this in previous PR.
I think that you need to leave the ability to edit the current cycle and leave checking the marked future dates.
@IraSoro based on steps that you described, looke like you confused this issue with #171 The problem what you described above is fixed in this PR #196. I checked by myself and everything works fine. And also you can see, that out of 4 commits from #196, 3 are completely duplicates commits from the current PR. And in this PR you can see why we don't need #178 anymore. User should be able to remove all days from cycle, if we'll leave this check then user will not be able to remove the current cycle in case it not finished yet |
I closed this PR because #196 has the same changs |
Fixed #166
In this PR I added possibility to save empty array of cycles. Also I removed
isMarkedFutureDays
because now we using ion-datetime built-in limitation instead of custom checksNew test has been added #192