Add team matching for club ambassadors #5363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-technovation
changed the title
shaun-technovation
force-pushed
the
preview
branch
from
2a816f6 to
4365d6f
Compare
This will let club ambassadors assign a student or a mentor to a team. Chapter ambassadors already had this functionality, to make it work for club ambassadors I extracted the existing functionality and made it so that both chapter ambassadors and club ambassadors can share the same functionality. Refs: #5331
shaun-technovation
force-pushed
the
5331-add-team-matching-for-club-ambassadors
branch
from
45e1912 to
57f0765
Compare
viviancan
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I was able to access the matching functionality as a CA & as a ChA - however I think the teams collection needs to be updated in app/controllers/ambassador/participants_controller.rb
as it is still using the "in region" functionality. When I selected the team dropdown to assign a mentor to a team in my chapter, there were no teams to select from (even though I had team on my team datagrid)
@teams = Team.current.in_region(current_ambassador)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let club ambassadors assign a student or a mentor to a team.
Chapter ambassadors already have this functionality, to make it work for club ambassadors I extracted the existing functionality and made it so that both chapter ambassadors and club ambassadors can share the same functionality.