Fix unaffilated list for club ambassadors not assigned to a club #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for a club ambassador to not be assigned to a club. If this happens they are still able to access the Club Admin Activity. The unaffiliated datagrid will error out if they're not assigned to a club (or chapter). ``` NoMethodError: undefined method `country_code' for #<NullChapterable:0x00007fd115046990> ``` This update will address this issue. Refs: #5371
shaun-technovation
force-pushed
the
5371-fix-unaffilated-datagrid-for-club-ambassadors-not-assigned-to-a-club
branch
from
42caa39 to
5ec7ab9
Compare
shaun-technovation
deleted the
5371-fix-unaffilated-datagrid-for-club-ambassadors-not-assigned-to-a-club
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for club ambassadors who aren't assigned to a club accessing the unaffiliated list.
Seems like an edge case since all club ambassadors should be assigned to a club; and if they're not maybe they shouldn't have access to certain things. Anywho, since it's possible now, this a simple fix for the time being.