impl. Island Delete Event #736
Conversation
| @@ -208,6 +209,8 @@ public void deleteTeam(Island island, User user) { | |||
| IridiumSkyblock.getInstance().getDatabaseManager().getIslandTableManager().delete(island); | |||
|
|
|||
| getMembersOnIsland(island).forEach(member -> PlayerUtils.teleportSpawn(member.getPlayer())); | |||
|
|
|||
| Bukkit.getPluginManager().callEvent(new IslandDeleteEvent(island, user)); | |||
There was a problem hiding this comment.
Should check the return value and not call the delete methods if the event is cancelled (hence calling it before like 209 with a if statement about the cancelled state
| Bukkit.getPluginManager().callEvent(islandDeleteEvent); | ||
|
|
||
| if (islandDeleteEvent.isCancelled()) { | ||
| return; |
There was a problem hiding this comment.
might be worth modifying this method to return a boolean.
In Teams, https://github.com/Iridium-Development/IridiumTeams/blob/master/src/main/java/com/iridium/iridiumteams/commands/DeleteCommand.java#L62 we will still send the deleted message. if this returns a boolean we can optionally send that.
Would require changing the https://github.com/Iridium-Development/IridiumTeams/blob/master/src/main/java/com/iridium/iridiumteams/managers/TeamManager.java#L89 Interface.
Feel free to open a PR in teams yourself, or ill do it myself over the weekend
No description provided.