Added new database serializer options #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sh0inx
commented
Jun 17, 2024
sh0inx
commented
- XBiome
- XEnchantment
- XEntityType (will need updating once match method is merged)
- XPotion
- XBiome - XEnchantment - XEntityType (will need updating once match method is merged) - XPotion
|
I would say if these fail to deserialize we potentially want to throw a warning log, and we potentially want to remove them from the database. Let me think more about this and get back to you. |
|
ill be honest, im not even sure if they're doing anything, i ran the database we received the report with through and it still broke (check nerd-chat) |
Did you update them on Skyblock's side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.