This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Feature/starknet #83
Closed
Feature/starknet #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseTheRobot
suggested changes
Aug 26, 2024
src/signing/chains/StarknetSigner.ts
Outdated
|
|
||
| static async verify(_pk: Buffer, message: Uint8Array, _signature: Uint8Array, _opts?: any): Promise<boolean> { | ||
| let message_to_felt = convertToFelt252(message); | ||
| let TypedDataMessage = typed_domain({ chainId: StarknetSigner.chainId, message: message_to_felt }); |
There was a problem hiding this comment.
chainId would be undefined here as nothing sets it (data item verification doesn't run the init function) - this would cause verification to fail.
I'd suggest adding the chainID to the public key/signature data so you can use it in the verify function.
src/signing/chains/StarknetSigner.ts
Outdated
| const pub_key = await signer.getPubKey(); | ||
| let hexKey = pub_key.startsWith("0x") ? pub_key.slice(2) : pub_key; | ||
| this.publicKey = Buffer.from(0 + hexKey, "hex"); | ||
| StarknetSigner.chainId = await StarknetSigner.provider.getChainId(); |
There was a problem hiding this comment.
overriding a static signer property is a very bad behaviour - right now your test cases pass because this change sticks around between test runs - if you removed this, or tried running verify before init, you would see that verification doesn't work
yarn.lock
Outdated
There was a problem hiding this comment.
CI reports that this yarn.lock is invalid
|
Hey @codeWhizperer - please copy this PR over to the new bundles repository |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.