Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ed25519-dalek 1.0.1 -> 2.1.1 #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ed25519-dalek 1.0.1 -> 2.1.1 #38

wants to merge 1 commit into from

Conversation

JesseTheRobot
Copy link
Member

This PR upgrades ed25519-dalek to 2.1.1 to fix compatibility with the latest version of Metaplex Sugar

@JesseTheRobot JesseTheRobot requested a review from mikonieminen May 3, 2024 12:37
mikonieminen
mikonieminen suggested changes May 4, 2024
View reviewed changes
Copy link
Contributor

@mikonieminen mikonieminen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is otherwise OK, but there are quite some clippy issues to fix. To allow tests to pass, we should have all of those fixed.

@JesseTheRobot JesseTheRobot force-pushed the feat/update-ed25519-dalek branch from 8458572 to f009e2c Compare May 4, 2024 09:27
@JesseTheRobot
Copy link
Member Author

This is otherwise OK, but there are quite some clippy issues to fix. To allow tests to pass, we should have all of those fixed.

Ah, I didn't get any locally due to the outdated rust version - I've updated and pushed the fixed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikonieminen mikonieminen mikonieminen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesseTheRobot @mikonieminen